fix(editor): Fix parameter reset on credential change in Discord node #9137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiloradFilipovic
requested changes
Apr 12, 2024
There was a problem hiding this comment.
Code looks ok but I have two comments on the solution:
- This doesn't solve the issue from the linear ticket (which I cannot reproduce so if the issue is not valid anymore it would be good to update the ticket or create a new one just so we keep linear tickets and PR in sync)
- I'm still encountering the issue where parameters are reset after changing the credentials:
Screen.Recording.2024-04-12.at.16.23.14.mov
|
@MiloradFilipovic Updated the linear issue description. The original issue is indeed no longer reproducible, see comment thread in Linear with Jon and Niklas. I think I missed the operation also being reset because I was testing with Message/Send (Send being the default operation), fixed now! 🎉 |
n8n-assistant
bot
added
community
Joffcom
added
n8n team
2 flaky tests on run #4705 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9137 ↗︎
|
✅ All Cypress E2E specs passed |
elsmr
deleted the
node-1089-discord-actions-not-being-seleted-after-selecting-them-in
branch
netroy
pushed a commit
that referenced
this pull request
Apr 18, 2024
Merged
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resource and operation parameters should not reset when credentials is changed.
The code that is looking for mismatched collection parameter options was also resetting options parameters.
Related to #8114
Related tickets and issues
https://linear.app/n8n/issue/NODE-1089/discord-actions-not-being-seleted-after-selecting-them-in-nodes-panel
Review / Merge checklist
(no-changelog)otherwise. (conventions)