Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Release 1.38.1 #9167

Merged
merged 1 commit into from
Apr 18, 2024
Merged

🚀 Release 1.38.1 #9167

merged 1 commit into from
Apr 18, 2024

Conversation

github-actions[bot]
Copy link
Contributor

1.38.1 (2024-04-18)

Bug Fixes

  • core: Exclude oAuth callback urls from browser-id checks (#9158) (c1d07fb)
  • core: Improve browserId checks, and add logging (#9161) (e16d18c)
  • editor: Fix parameter reset on credential change in Discord node (#9137) (336344f)
  • Postgres Node: Convert js arrays to postgres type, if column type is ARRAY (#9160) (ee0c685)
  • Schedule Trigger Node: Default to 0 minute if falsy on hourly run (#9146) (3d6455e)

@netroy
Copy link
Member

netroy commented Apr 18, 2024

DB Tests
E2E Tests

Copy link
Contributor Author

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Apr 18, 2024

1 failed and 3 flaky tests on run #4723 ↗︎

1 354 12 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 github-actions[bot] 🗃️ e2e/*
Project: n8n Commit: 77d6dcf8ae
Status: Failed Duration: 04:35 💡
Started: Apr 18, 2024 3:01 PM Ended: Apr 18, 2024 3:06 PM
Failed  cypress/e2e/8-http-request-node.cy.ts • 1 failed test

View Output Video

Test Artifacts
HTTP Request node > should make a request with a URL and receive a response Test Replay Screenshots Video
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #9167 ↗︎

@netroy netroy merged commit 081d1c9 into release/1.38.1 Apr 18, 2024
26 of 29 checks passed
@netroy netroy deleted the 1.38.1-pr branch April 18, 2024 15:13
@netroy
Copy link
Member

netroy commented Apr 18, 2024

Failing e2e tests is due to an external service call not responding in time. ignoring it for now to unblock the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant