fix(Schedule Trigger Node): Default to 0 minute if falsy on hourly run #9146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
n8n team
elsmr
reviewed
Apr 17, 2024
| const minute = interval[i].triggerAtMinute?.toString() as string; | ||
| let minute = interval[i].triggerAtMinute?.toString() as string; | ||
| if (!minute && nodeVersion >= 1.2) { | ||
| minute = '0'; |
There was a problem hiding this comment.
Doesn't the same issue exist in a lot of other places in the Schedule node? You can delete any number field, and we don't set a fallback
There was a problem hiding this comment.
good point, will push update
…schedule-trigger-node-missing-minute-field-on-hourly-run
4 flaky tests on run #4713 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
17-sharing.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Sharing > should work for admin role on credentials created by others (also can share it with themselves) |
Test Replay
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9146 ↗︎
|
✅ All Cypress E2E specs passed |
michael-radency
deleted the
node-1244-schedule-trigger-node-missing-minute-field-on-hourly-run
branch
netroy
pushed a commit
that referenced
this pull request
Apr 18, 2024
Merged
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you add a schedule trigger node and set it to hourly and delete the minute field content the node will run every minute.
Related tickets and issues
https://linear.app/n8n/issue/NODE-1244/schedule-trigger-node-missing-minute-field-on-hourly-run