Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Enable expression preview in SQL node when looking at executions #9733

Conversation

cstuncsik
Copy link
Contributor

Summary

SQL node does not show expression resolution preview when viewing executions

Related Linear tickets, Github issues, and Community forum posts

PAY-1263

Review / Merge checklist

  • PR title and summary are descriptive.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jun 13, 2024
…xpression-evaluations-in-sql-editoreg-when-viewing
Copy link

cypress bot commented Jun 26, 2024

3 flaky tests on run #5697 ↗︎

0 396 0 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project: n8n Commit: f9d8d9d468
Status: Passed Duration: 05:16 💡
Started: Jun 27, 2024 2:54 PM Ended: Jun 27, 2024 2:59 PM
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  10-undo-redo.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding nodes Test Replay Screenshots Video

Review all test suite changes for PR #9733 ↗︎

@cstuncsik cstuncsik marked this pull request as ready for review June 26, 2024 13:24
Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik changed the title fix(editor): Turn Sql node input to expression to show preview fix(editor): Enable preview in SQL node when looking at executions Jun 27, 2024
@cstuncsik cstuncsik changed the title fix(editor): Enable preview in SQL node when looking at executions fix(editor): Enable expression preview in SQL node when looking at executions Jun 27, 2024
@cstuncsik cstuncsik merged commit d9747d5 into master Jun 27, 2024
29 checks passed
@cstuncsik cstuncsik deleted the pay-1263-cant-see-expression-evaluations-in-sql-editoreg-when-viewing branch June 27, 2024 15:07
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
@janober
Copy link
Member

janober commented Jul 3, 2024

Got released with n8n@1.49.0

adrian-martinez-onestic pushed a commit to onesdata/n8n-fork that referenced this pull request Jul 8, 2024
…ecutions (n8n-io#9733)

Co-authored-by: Elias Meire <elias@meire.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants