-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Enable expression preview in SQL node when looking at executions #9733
Merged
cstuncsik
merged 4 commits into
master
from
pay-1263-cant-see-expression-evaluations-in-sql-editoreg-when-viewing
Jun 27, 2024
Merged
fix(editor): Enable expression preview in SQL node when looking at executions #9733
cstuncsik
merged 4 commits into
master
from
pay-1263-cant-see-expression-evaluations-in-sql-editoreg-when-viewing
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Authored by the n8n team
node/improvement
New feature or request
labels
Jun 13, 2024
…xpression-evaluations-in-sql-editoreg-when-viewing
3 flaky tests on run #5697 ↗︎
Details:
5-ndv.cy.ts • 2 flaky tests
10-undo-redo.cy.ts • 1 flaky test
Review all test suite changes for PR #9733 ↗︎ |
elsmr
approved these changes
Jun 27, 2024
✅ All Cypress E2E specs passed |
cstuncsik
changed the title
fix(editor): Turn Sql node input to expression to show preview
fix(editor): Enable preview in SQL node when looking at executions
Jun 27, 2024
cstuncsik
changed the title
fix(editor): Enable preview in SQL node when looking at executions
fix(editor): Enable expression preview in SQL node when looking at executions
Jun 27, 2024
cstuncsik
deleted the
pay-1263-cant-see-expression-evaluations-in-sql-editoreg-when-viewing
branch
June 27, 2024 15:07
Merged
Got released with |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jul 8, 2024
…ecutions (n8n-io#9733) Co-authored-by: Elias Meire <elias@meire.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SQL node does not show expression resolution preview when viewing executions
Related Linear tickets, Github issues, and Community forum posts
PAY-1263
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)