Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Add localStorage flag to prevent opening NDV in new canvas (no-changelog) #10187

Merged

Conversation

alexgrozav
Copy link
Contributor

Summary

Adds NodeView.preventOpeningNDV localStorage flag to prevent opening NDV after adding a node, used for demo purposes.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/N8N-7510/as-a-user-i-want-to-be-able-to-disable-opening-ndv-automatically-after

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Jul 25, 2024
elsmr
elsmr previously approved these changes Jul 25, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 25, 2024
Copy link

cypress bot commented Jul 25, 2024

Passing run #6137 ↗︎

0 388 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project: n8n Commit: 1d5dcddcad
Status: Passed Duration: 04:10 💡
Started: Jul 25, 2024 12:34 PM Ended: Jul 25, 2024 12:39 PM

Review all test suite changes for PR #10187 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 5929351 into master Jul 25, 2024
28 checks passed
@alexgrozav alexgrozav deleted the n8n-7510-as-a-user-i-want-to-be-able-to-disable-opening-ndv branch July 25, 2024 13:00
cstuncsik pushed a commit that referenced this pull request Jul 31, 2024
@janober
Copy link
Member

janober commented Jul 31, 2024

Got released with n8n@1.53.0

cstuncsik pushed a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants