Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HubSpot Node): Overhaul the HubSpot Node #4337

Merged
merged 70 commits into from
May 8, 2023

Conversation

agobrech
Copy link
Contributor

No description provided.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request node/new Creation of an entirely new node labels Oct 13, 2022
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@agobrech agobrech changed the title feat(Hubspot Node): refactor the Hubspot Node feat(HubSpot Node): refactor the Hubspot Node Mar 21, 2023
@agobrech agobrech changed the title feat(HubSpot Node): refactor the Hubspot Node feat(HubSpot Node): Overhaul the HubSpot Node Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.23 ⚠️

Comparison is base (8862e1e) 19.97% compared to head (960152f) 19.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4337      +/-   ##
==========================================
- Coverage   19.97%   19.75%   -0.23%     
==========================================
  Files        2621     2631      +10     
  Lines      118062   119391    +1329     
  Branches    18516    18854     +338     
==========================================
  Hits        23585    23585              
- Misses      93766    95093    +1327     
- Partials      711      713       +2     
Impacted Files Coverage Δ
packages/nodes-base/nodes/Hubspot/Hubspot.node.ts 0.00% <0.00%> (ø)
...es/nodes-base/nodes/Hubspot/HubspotTrigger.node.ts 0.00% <0.00%> (ø)
.../nodes-base/nodes/Hubspot/V1/CompanyDescription.ts 0.00% <ø> (ø)
.../nodes-base/nodes/Hubspot/V1/ContactDescription.ts 0.00% <ø> (ø)
...es-base/nodes/Hubspot/V1/ContactListDescription.ts 0.00% <ø> (ø)
...ges/nodes-base/nodes/Hubspot/V1/DealDescription.ts 0.00% <ø> (ø)
...des-base/nodes/Hubspot/V1/EngagementDescription.ts 0.00% <ø> (ø)
...ges/nodes-base/nodes/Hubspot/V1/FormDescription.ts 0.00% <ø> (ø)
...es/nodes-base/nodes/Hubspot/V1/GenericFunctions.ts 0.00% <0.00%> (ø)
...ages/nodes-base/nodes/Hubspot/V1/HubspotV1.node.ts 0.00% <0.00%> (ø)
... and 10 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@maspio maspio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

✅ All Cypress E2E specs passed

@agobrech agobrech merged commit 2913e67 into master May 8, 2023
@agobrech agobrech deleted the n8n-4554-hubspot-node-redesign branch May 8, 2023 13:15
MiloradFilipovic added a commit that referenced this pull request May 9, 2023
* master: (31 commits)
  feat(Date & Time Node): Overhaul of the node (#5904)
  refactor: Add deprecation notice for WEBHOOK_TUNNEL_URL (#6194)
  refactor: Add deprecation notice for WEBHOOK_TUNNEL_URL (#6194)
  feat(HubSpot Node): Overhaul the HubSpot Node (#4337)
  ci: Create a nightly v1 docker image (no-changelog) (#6197)
  refactor(core): Add deprecation notice for own mode (#6195)
  feat(core): Update config defaults for for v1 (no-changelog) (#6196)
  test(Read Binary Files Node): Unit tests (no-changelog) (#5459)
  refactor: Add deprecation notice for MySQL and MariaDB (#6189)
  test: Create custom jest error messages using jest-expect-message (no-changelog) (#5666)
  fix(core): Move nodeExecute InternalHook calls to hookFunctionsSave (#6193)
  fix(FTP Node): Use filename instead of remote filepath for downloaded binary data (#6170)
  ci: Fix test database cleanup (no-changelog) (#6188)
  refactor(core): Delete boilerplate code across migrations (no-changelog) (#5254)
  refactor(editor): Add infix to Pinia stores (no-changelog) (#6149)
  ci: Fix linting issues on master (no-changelog) (#6186)
  fix(editor): Update and add design system checkbox component to Editor (#6178)
  fix(editor): Display SSO entry in Settings on Cloud (#6181)
  feat(Code Node): Add Python support (#4295)
  fix(editor): Update and fix storybook (was failing to run in local dev mode) (#6180)
  ...

# Conflicts:
#	packages/editor-ui/src/stores/nodeTypes.store.ts
#	packages/nodes-base/nodes/Postgres/Postgres.node.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/versionDescription.ts
MiloradFilipovic added a commit that referenced this pull request May 9, 2023
…rce-mapper-ui-P2

* feature/resource-mapping-component: (31 commits)
  feat(Date & Time Node): Overhaul of the node (#5904)
  refactor: Add deprecation notice for WEBHOOK_TUNNEL_URL (#6194)
  refactor: Add deprecation notice for WEBHOOK_TUNNEL_URL (#6194)
  feat(HubSpot Node): Overhaul the HubSpot Node (#4337)
  ci: Create a nightly v1 docker image (no-changelog) (#6197)
  refactor(core): Add deprecation notice for own mode (#6195)
  feat(core): Update config defaults for for v1 (no-changelog) (#6196)
  test(Read Binary Files Node): Unit tests (no-changelog) (#5459)
  refactor: Add deprecation notice for MySQL and MariaDB (#6189)
  test: Create custom jest error messages using jest-expect-message (no-changelog) (#5666)
  fix(core): Move nodeExecute InternalHook calls to hookFunctionsSave (#6193)
  fix(FTP Node): Use filename instead of remote filepath for downloaded binary data (#6170)
  ci: Fix test database cleanup (no-changelog) (#6188)
  refactor(core): Delete boilerplate code across migrations (no-changelog) (#5254)
  refactor(editor): Add infix to Pinia stores (no-changelog) (#6149)
  ci: Fix linting issues on master (no-changelog) (#6186)
  fix(editor): Update and add design system checkbox component to Editor (#6178)
  fix(editor): Display SSO entry in Settings on Cloud (#6181)
  feat(Code Node): Add Python support (#4295)
  fix(editor): Update and fix storybook (was failing to run in local dev mode) (#6180)
  ...

# Conflicts:
#	packages/editor-ui/src/stores/nodeTypes.store.ts
@janober
Copy link
Member

janober commented May 25, 2023

Got released with n8n@0.228.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request node/new Creation of an entirely new node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants