Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Microsoft Teams Node): Use resource locator component for chat, channels and tasks #4539

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from
Draft

feat(Microsoft Teams Node): Use resource locator component for chat, channels and tasks #4539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
8395b64
Chat Message -> Get Many -> rollout Chat param RLC
maspio Nov 7, 2022
9a3e1e0
Chat Message -> Create -> rollout Chat param RLC
maspio Nov 10, 2022
06a3c7e
Chat Message -> GetMany/Create -> support RLC by URL
maspio Nov 18, 2022
5954da9
Chat Message -> Get/GetMany/Create -> fix RLC by ID url
maspio Nov 18, 2022
a2e9b37
Chat Message -> Get -> rollout Chat param RLC
maspio Nov 18, 2022
f8481cf
Remove unused loadOption getChats
maspio Nov 18, 2022
da7de81
Merge branch 'master' into n8n-5173-microsoft-teams-node-roll-out-res…
maspio Nov 18, 2022
5d2e900
Channel -> All operations -> parameter Team RLC (before merge master)
maspio Nov 18, 2022
8a0885e
Merge branch 'master' into n8n-5173-microsoft-teams-node-roll-out-res…
maspio Nov 18, 2022
a8114be
Merge branch 'master' into n8n-5173-microsoft-teams-node-roll-out-res…
maspio Nov 18, 2022
49a6f0c
Channel -> All operations -> parameter Team RLC
maspio Nov 21, 2022
7c35389
Channel Message -> All operations -> parameter Team RLC
maspio Nov 21, 2022
b210437
removed unused loadOptions method getTeams
maspio Nov 21, 2022
f39308c
Channel -> Get/Delete/Update -> parameter Channel RLC
maspio Nov 23, 2022
07f46da
Channel Message -> All operations -> parameter Channel RLC
maspio Nov 23, 2022
9a8f8bb
remove unused loadOptions method getChannels
maspio Nov 23, 2022
fe4a136
Merge branch 'master' into n8n-5173-microsoft-teams-node-roll-out-res…
maspio Nov 23, 2022
a070074
fix eslint errors after merging master
maspio Nov 23, 2022
0ce70a6
🐛 fix getCurrentNodeParameter with extractValue if no returnData
maspio Nov 30, 2022
2b9d7dc
Task -> Create/GetALL/Update -> parameter Group RLC
maspio Nov 30, 2022
9f4c5c1
🔨 - remove unused loadOptions method getGroups
maspio Nov 30, 2022
802a004
Task -> Create/GetALL/Update -> parameter Plan RLC
maspio Dec 6, 2022
641a631
🔨 - remove unused loadOptions method getPlans
maspio Dec 6, 2022
ddb183f
Task -> Create/GetALL/Update -> parameter Member RLC
maspio Dec 8, 2022
bdf1c81
🔨 - remove unused loadOptions method getMembers
maspio Dec 8, 2022
53abe21
Task -> Create/Update -> parameter BucketID RLC
maspio Dec 19, 2022
ede4a35
🔨 - remove unused loadOptions method getBuckets
maspio Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/NodeExecuteFunctions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2684,7 +2684,7 @@ export function getLoadOptionsFunctions(
let returnData = get(nodeParameters, parameterPath);

// This is outside the try/catch because it throws errors with proper messages
if (options?.extractValue) {
if (returnData && options?.extractValue) {
const nodeType = workflow.nodeTypes.getByNameAndVersion(node.type, node.typeVersion);
if (nodeType === undefined) {
throw new Error(
Expand Down
Loading