fix(core): Do not explicitly bypass auth on urls containing .svg
#5525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
changed the title
.svg.svg
n8n-assistant
bot
added
core
netroy
force-pushed
the
fix-svg-auth-bypass
branch
from
0787c3d
to
2bd2f64
Compare
All valid exclusions are already in the `isAuthExcluded` function. The removed lines aren't used anymore, and are safe to delete.
netroy
force-pushed
the
fix-svg-auth-bypass
branch
from
2bd2f64
to
450bc32
Compare
krynble
approved these changes
Feb 21, 2023
n8n-assistant
bot
added
the
Upcoming Release
janober
pushed a commit
that referenced
this pull request
Feb 21, 2023
janober
added a commit
that referenced
this pull request
Feb 21, 2023
* 🚀 Release 0.216.1 * fix(core): Do not allow arbitrary path traversal in the credential-translation endpoint (#5522) * fix(core): Do not allow arbitrary path traversal in BinaryDataManager (#5523) * fix(core): User update endpoint should only allow updating email, firstName, and lastName (#5526) * fix(core): Do not explicitly bypass auth on urls containing `.svg` (#5525) * 📚 Update CHANGELOG.md --------- Co-authored-by: janober <janober@users.noreply.github.com> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com> Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
|
Got released with |
netroy
added a commit
to netroy/n8n
that referenced
this pull request
Feb 23, 2023
netroy
added a commit
that referenced
this pull request
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.