Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upsert workflow statistics to suppress unnecessary error messages #5863

Merged
merged 2 commits into from Apr 4, 2023

Conversation

krynble
Copy link
Contributor

@krynble krynble commented Mar 31, 2023

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 59.37% and project coverage change: +0.18 🎉

Comparison is base (744c3fd) 14.84% compared to head (2ca2cc4) 15.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5863      +/-   ##
==========================================
+ Coverage   14.84%   15.03%   +0.18%     
==========================================
  Files        2475     2476       +1     
  Lines      113363   113464     +101     
  Branches    17702    17748      +46     
==========================================
+ Hits        16826    17055     +229     
+ Misses      95990    95826     -164     
- Partials      547      583      +36     
Impacted Files Coverage Δ
packages/cli/src/events/WorkflowStatistics.ts 69.35% <59.37%> (-7.57%) ⬇️

... and 101 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netroy netroy merged commit 2b06673 into master Apr 4, 2023
22 checks passed
@netroy netroy deleted the pay-144-duplicate-key-value-violates-unique branch April 4, 2023 16:11
@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with n8n@0.223.0

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants