Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core)!: Remove basic-auth, external-jwt-auth, and no-auth options #6362

Merged
merged 8 commits into from Jun 7, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jun 2, 2023

@ivov ivov added the v1 Issues related to the release of n8n version 1.x.x label Jun 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Great PR! Please pay attention to the following items before merging:

Files matching cypress/e2e/**:

  • Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
  • Spoofed endpoints that are not critical for the test (to avoid flakiness).
  • Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
  • Avoided adding waits on time (use request intercepts instead).
  • Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-v1@435baa2). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##             release-v1    #6362   +/-   ##
=============================================
  Coverage              ?   28.22%           
=============================================
  Files                 ?     2978           
  Lines                 ?   184966           
  Branches              ?    20262           
=============================================
  Hits                  ?    52204           
  Misses                ?   131980           
  Partials              ?      782           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ivov ivov changed the base branch from master to release-v1 June 2, 2023 10:15
@ivov ivov marked this pull request as ready for review June 5, 2023 09:28
@ivov ivov requested a review from a team as a code owner June 5, 2023 09:28
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jun 5, 2023
@netroy netroy self-requested a review June 7, 2023 08:55
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Jun 7, 2023

Passing run #1140 ↗︎

0 223 0 0 Flakiness 0

Details:

🌳 n8n-6250-streamline-auth-for-v1 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃...
Project: n8n Commit: e24a1aa8f9
Status: Passed Duration: 07:35 💡
Started: Jun 7, 2023 2:12 PM Ended: Jun 7, 2023 2:19 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

✅ All Cypress E2E specs passed

@netroy netroy changed the title refactor: Streamline auth for v1 refactor(core)!: Remove basic-auth, external-jwt-auth, and no-auth options Jun 7, 2023
@netroy netroy merged commit b483994 into release-v1 Jun 7, 2023
56 checks passed
@netroy netroy deleted the n8n-6250-streamline-auth-for-v1 branch June 7, 2023 14:53
netroy added a commit that referenced this pull request Jun 22, 2023
…tions (#6362)

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
@netroy netroy mentioned this pull request Jun 27, 2023
@janober
Copy link
Member

janober commented Jul 26, 2023

Got released with n8n@1.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released v1 Issues related to the release of n8n version 1.x.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants