Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Stop loading community nodes from node_modules #6396

Merged
merged 1 commit into from Jun 7, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Jun 7, 2023

All community nodes should be installed in ~/.n8n/nodes.

N8N-6251

@netroy netroy added the v1 Issues related to the release of n8n version 1.x.x label Jun 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-v1@16d5579). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 1bb9301 differs from pull request most recent head e444031. Consider uploading reports for the commit e444031 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             release-v1    #6396   +/-   ##
=============================================
  Coverage              ?   28.24%           
=============================================
  Files                 ?     2981           
  Lines                 ?   185168           
  Branches              ?    20296           
=============================================
  Hits                  ?    52294           
  Misses                ?   132087           
  Partials              ?      787           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

All custom/community nodes should be installed in `~/.n8n/nodes`.
@netroy netroy force-pushed the N8N-6251-ignore-custom-nodes-in-node_modules branch from 1bb9301 to e444031 Compare June 7, 2023 11:40
@netroy netroy merged commit 770e11d into release-v1 Jun 7, 2023
11 checks passed
@netroy netroy deleted the N8N-6251-ignore-custom-nodes-in-node_modules branch June 7, 2023 11:58
netroy added a commit that referenced this pull request Jun 7, 2023
All custom/community nodes should be installed in `~/.n8n/nodes`.
netroy added a commit that referenced this pull request Jun 22, 2023
All custom/community nodes should be installed in `~/.n8n/nodes`.
@netroy netroy mentioned this pull request Jun 27, 2023
@janober
Copy link
Member

janober commented Jul 26, 2023

Got released with n8n@1.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released v1 Issues related to the release of n8n version 1.x.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants