Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removal of request lib from the code #6413

Merged
merged 3 commits into from Jun 14, 2023
Merged

Conversation

krynble
Copy link
Contributor

@krynble krynble commented Jun 13, 2023

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/package.json:

  • Avoided adding dependencies for nodes if not absolutely necessary.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-v1@9b9bef6). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##             release-v1    #6413   +/-   ##
=============================================
  Coverage              ?   28.21%           
=============================================
  Files                 ?     2978           
  Lines                 ?   184958           
  Branches              ?    20260           
=============================================
  Hits                  ?    52193           
  Misses                ?   131983           
  Partials              ?      782           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@krynble krynble marked this pull request as ready for review June 14, 2023 07:25
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove @types/request-promise-native as well?

@krynble krynble merged commit 8f99100 into release-v1 Jun 14, 2023
13 of 14 checks passed
@krynble krynble deleted the remove-request-lib branch June 14, 2023 14:40
@krynble
Copy link
Contributor Author

krynble commented Jun 15, 2023

@ivov unfortunately not yet, the workflow package still relies on it to work and build. The good thing is that this is only necessary for building, not being bundled in the final app

netroy pushed a commit that referenced this pull request Jun 22, 2023
* refactor: Removal of request lib from the code
@netroy netroy mentioned this pull request Jun 27, 2023
@janober
Copy link
Member

janober commented Jul 26, 2023

Got released with n8n@1.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants