Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core)!: Make date extensions outputs match inputs #6435

Merged
merged 2 commits into from Jun 15, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jun 14, 2023

Ensure that native JS dates remain native JS dates, and that luxon dates remain luxon dates.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jun 14, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@ivov ivov added the v1 Issues related to the release of n8n version 1.x.x label Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-v1@9b9bef6). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##             release-v1    #6435   +/-   ##
=============================================
  Coverage              ?   28.21%           
=============================================
  Files                 ?     2978           
  Lines                 ?   184957           
  Branches              ?    20262           
=============================================
  Hits                  ?    52187           
  Misses                ?   131987           
  Partials              ?      783           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@valya valya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see any issues but some tests for plus and minus would be good to see at some point.

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Jun 14, 2023

12 failed and 1 flaky tests on run #1199 ↗︎

12 119 0 0 Flakiness 1

Details:

🌳 n8n-6252-make-date-extensions-outputs-match-inputs 🖥️ browsers:node18.12.0-c...
Project: n8n Commit: 93c0dfb46a
Status: Failed Duration: 44:34 💡
Started: Jun 15, 2023 7:42 AM Ended: Jun 15, 2023 8:26 AM
Failed  18-user-management.cy.ts • 12 failed tests

View Output Video

Test Artifacts
User Management > should invite User B and User C to instance Output Screenshots Video
User Management > should prevent non-owners to access UM settings Output Screenshots Video
User Management > should allow instance owner to access UM settings Output Screenshots Video
User Management > should properly render UM settings page for instance owners Output Screenshots Video
User Management > should delete user and their data Output Screenshots Video
User Management > should delete user and transfer their data Output Screenshots Video
User Management > should allow user to change their personal data Output Screenshots Video
User Management > shouldn't allow user to set weak password Output Screenshots Video
User Management > shouldn't allow user to change password if old password is wrong Output Screenshots Video
User Management > should change current user password Output Screenshots Video
The first 10 failed tests are shown, see all 12 tests in Cypress Cloud.
Failed  14-data-transformation-expressions.cy.ts • 0 failed tests

View Output Video

Test Artifacts
Failed  17-sharing.cy.ts • 0 failed tests

View Output Video

Test Artifacts
Failed  24-ndv-paired-item.cy.ts • 0 failed tests

View Output Video

Test Artifacts
Failed  14-mapping.cy.ts • 0 failed tests

View Output Video

Test Artifacts

The first 5 failed specs are shown, see all 21 specs in Cypress Cloud.

Flakiness  cypress/e2e/12-canvas.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Canvas Node Manipulation and Navigation > should add switch node and test connections Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ivov ivov merged commit ce59e8a into release-v1 Jun 15, 2023
30 of 56 checks passed
@ivov ivov deleted the n8n-6252-make-date-extensions-outputs-match-inputs branch June 15, 2023 08:07
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@janober
Copy link
Member

janober commented Jul 26, 2023

Got released with n8n@1.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released v1 Issues related to the release of n8n version 1.x.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants