New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core)!: Make date extensions outputs match inputs #6435
fix(core)!: Make date extensions outputs match inputs #6435
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-v1 #6435 +/- ##
=============================================
Coverage ? 28.21%
=============================================
Files ? 2978
Lines ? 184957
Branches ? 20262
=============================================
Hits ? 52187
Misses ? 131987
Partials ? 783 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't see any issues but some tests for plus
and minus
would be good to see at some point.
|
|
Got released with |
Ensure that native JS dates remain native JS dates, and that luxon dates remain luxon dates.