Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LinkedIn Node): Remove unsupported description from image posts #6446

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Jun 15, 2023

Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/linkedin-post-error/27011/13

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jun 15, 2023
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 81.13% and project coverage change: -0.07 ⚠️

Comparison is base (ae56ac9) 28.37% compared to head (1d853f2) 28.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6446      +/-   ##
==========================================
- Coverage   28.37%   28.30%   -0.07%     
==========================================
  Files        2991     2991              
  Lines      185889   185900      +11     
  Branches    20474    20477       +3     
==========================================
- Hits        52742    52624     -118     
- Misses     132355   132483     +128     
- Partials      792      793       +1     
Impacted Files Coverage Δ
...kages/nodes-base/nodes/ItemLists/ItemLists.node.ts 100.00% <ø> (ø)
...ackages/nodes-base/nodes/LinkedIn/LinkedIn.node.ts 0.00% <ø> (ø)
...kages/nodes-base/nodes/LinkedIn/PostDescription.ts 0.00% <ø> (ø)
.../nodes-base/nodes/ItemLists/V2/ItemListsV2.node.ts 33.84% <81.13%> (+2.73%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Jun 16, 2023

Passing run #1219 ↗︎

0 227 0 0 Flakiness 0

Details:

🌳 fix/linkedin-images 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project: n8n Commit: 1d853f2939
Status: Passed Duration: 08:16 💡
Started: Jun 16, 2023 9:05 AM Ended: Jun 16, 2023 9:13 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit 529f0e4 into master Jun 16, 2023
@Joffcom Joffcom deleted the fix/linkedin-images branch June 16, 2023 09:13
MiloradFilipovic added a commit that referenced this pull request Jun 20, 2023
* master: (34 commits)
  feat(editor): Replace root events with event bus events (no-changelog) (#6454)
  feat(DebugHelper Node): Fix and include in main app (#6406)
  feat(Webhook Node): Stream binary response in `lastNode.firstEntryBinary` mode (#6463)
  fix(editor): Update git repo URL validation to prevent using https protocol (#6475)
  fix(editor): Remove tooltip about SMTP being required to invite user (no-changelog) (#6474)
  feat: Add support for large files with declarative nodes (#6461)
  fix(core): Fix the url sent in the password-reset emails (#6466)
  fix(HTML Node): Prevent XSS in execution-data preview (#6432)
  fix(Snowflake Node): Upgrade snowflake-sdk to address CVE-2023-34232 (no-changelog) (#6458)
  refactor(core): Replace lodash's "soft-deprecated" individual packages with `lodash` to resolve CVE (no-changelog) (#6450)
  fix(editor): Remove `$if`, `$min` and `$max` from code node autocomplete (#6460)
  fix(editor): Fix DNV header disappearing when scrolling the code editor content (#6459)
  feat: Remove vue-fragment (no-changelog) (#6456)
  ci: Prevent e2e failure on `commented` type review (no-changelog) (#6452)
  fix(LinkedIn Node): Remove unsupported description from image posts (#6446)
  fix(Split In Batches Node): Add "done" context to allow simple reset (#6437)
  feat(Gmail Node): Add reply to email (#6453)
  fix: Remove Vue.component usage and refactor plugins into Vue Plugins (no-changelog) (#6445)
  fix(editor): Show confirm on pull only when http response status is 409 (#6451)
  fix(editor): Update data pinning tooltip to match current behaviour (#6436)
  ...

# Conflicts:
#	packages/nodes-base/nodes/CompareDatasets/GenericFunctions.ts
#	packages/nodes-base/nodes/Merge/v2/GenericFunctions.ts
@janober
Copy link
Member

janober commented Jun 22, 2023

Got released with n8n@0.234.0

@cbalbinos
Copy link

with version 0.236.0 the error returned

image

@Joffcom
Copy link
Member Author

Joffcom commented Jul 8, 2023

Hey @cbalbinos

Seems to be working for me, can you open a thread on the support forum and include your workflow so we can take a look.

@cbalbinos
Copy link

Hey @Joffcom

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants