Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Strapi Node): Add token credentials #7048

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Aug 30, 2023

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Files matching packages/nodes-base/package.json:

  • Avoided adding dependencies for nodes if not absolutely necessary.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (3b9f0fe) 32.10% compared to head (a65a83b) 32.10%.

❗ Current head a65a83b differs from pull request most recent head 18f6afd. Consider uploading reports for the commit 18f6afd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7048      +/-   ##
==========================================
- Coverage   32.10%   32.10%   -0.01%     
==========================================
  Files        3186     3187       +1     
  Lines      195791   195804      +13     
  Branches    21353    21352       -1     
==========================================
- Hits        62861    62859       -2     
- Misses     131896   131911      +15     
  Partials     1034     1034              
Files Changed Coverage Δ
...des-base/credentials/StrapiTokenApi.credentials.ts 0.00% <0.00%> (ø)
...ckages/nodes-base/nodes/Strapi/GenericFunctions.ts 0.00% <0.00%> (ø)
packages/nodes-base/nodes/Strapi/Strapi.node.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elsmr elsmr marked this pull request as ready for review August 30, 2023 13:24
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Aug 30, 2023
Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cypress
Copy link

cypress bot commented Aug 31, 2023

1 flaky test on run #2039 ↗︎

0 233 0 0 Flakiness 1

Details:

🌳 node-551-token-authentication-for-strapi 🖥️ browsers:node18.12.0-chrome107 ?...
Project: n8n Commit: 18f6afdcf3
Status: Passed Duration: 07:05 💡
Started: Aug 31, 2023 4:41 AM Ended: Aug 31, 2023 4:48 AM
Flakiness  cypress/e2e/2-credentials.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Credentials > should create a new credential using Add Credential button Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit c01bca5 into master Aug 31, 2023
50 of 51 checks passed
@elsmr elsmr deleted the node-551-token-authentication-for-strapi branch August 31, 2023 10:46
@github-actions github-actions bot mentioned this pull request Aug 31, 2023
netroy added a commit that referenced this pull request Aug 31, 2023
## [1.5.1](https://github.com/n8n-io/n8n/compare/n8n@1.5.0...n8n@1.5.1)
(2023-08-31)


### Features

* **Strapi Node:** Add token credentials
([#7048](#7048))
([c01bca5](c01bca5))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Aug 31, 2023
netroy added a commit that referenced this pull request Aug 31, 2023
## [1.5.1](https://github.com/n8n-io/n8n/compare/n8n@1.5.0...n8n@1.5.1)
(2023-08-31)


### Features

* **Strapi Node:** Add token credentials
([#7048](#7048))
([c01bca5](c01bca5))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Aug 31, 2023

Got released with n8n@1.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants