feat(editor): Add routing middleware, permission checks, RBAC store, RBAC component #7702

alexgrozav · 2023-11-14T07:57:56Z

Github issue / Community forum post (link here to close automatically):

cstuncsik · 2023-11-14T10:52:51Z

packages/editor-ui/src/middleware/enterprise.ts

+
+	let valid: boolean;
+	if (mode === 'allOf') {
+		valid = options.features.every((feature) => settingsStore.isEnterpriseFeatureEnabled(feature));


just a nitpick (coming from my functional programming self :))
it could be pointfree (same below)

Suggested change

valid = options.features.every((feature) => settingsStore.isEnterpriseFeatureEnabled(feature));

valid = options.features.every(settingsStore.isEnterpriseFeatureEnabled);

cstuncsik · 2023-11-14T10:55:43Z

packages/editor-ui/src/stores/rbac.store.ts

+			resourceId: string;
+		},
+	) {
+		if (!scopesByResourceId.value[context.resourceType][context.resourceId]) {


maybe you could save these long object accesses to a variable to avoid the repetition

cstuncsik · 2023-11-14T11:08:10Z

packages/editor-ui/src/utils/rbacUtils.ts

+export function inferResourceTypeFromRoute(to: RouteLocationNormalized): Resource | undefined {
+	const routeParts = to.path.split('/');
+
+	switch (true) {


you could reduce some repetition with just using an object and a forOf loop

const hash = { workflow: 'workflows', sourceControl: 'source-control', } for (const resource of hash) { if(routeParts.includes(hash[resource])) { return resource } }

Awesome idea! Thanks!

cstuncsik

Nice work! I like the middlewares
Left some coding style nitpicks but apart from that it looks good

github-actions · 2023-11-14T11:25:09Z

⚠️ Some Cypress E2E specs are failing, please fix them before merging

cypress · 2023-11-14T11:25:15Z

2 flaky tests on run #3000 ↗︎

0	282	5	0	2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project: n8n	Commit: `1eba64028f`
Status: Passed	Duration: 05:47 💡
Started: Nov 23, 2023 11:12 AM	Ended: Nov 23, 2023 11:18 AM

12-canvas.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
Canvas Node Manipulation and Navigation > should add merge node and test connections		`Screenshots` `Video`

26-resource-locator.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
Resource Locator > should retrieve list options when other params throw errors		`Screenshots` `Video`

Review all test suite changes for PR #7702 ↗︎

alexgrozav · 2023-11-15T14:03:23Z

packages/editor-ui/src/stores/users.store.ts

+			const defaultScopes: Scope[] = [];
+			if (isInstanceOwner(user)) {
+				defaultScopes.push('tag:delete');
+			}
+
+			useRBACStore().setGlobalScopes(user.globalScopes || defaultScopes);


@cstuncsik This code needs to be updated once Back End returns globalScopes.

github-actions · 2023-11-15T15:15:04Z

⚠️ Some Cypress E2E specs are failing, please fix them before merging

…permissions-overhaul

…n8n-io/n8n into pay-1005-front-end-permissions-overhaul

github-actions · 2023-11-21T17:14:24Z

⚠️ Some Cypress E2E specs are failing, please fix them before merging

github-actions · 2023-11-21T20:47:39Z

✅ All Cypress E2E specs passed

github-actions · 2023-11-22T05:57:17Z

✅ All Cypress E2E specs passed

…permissions-overhaul

github-actions · 2023-11-23T11:18:21Z

✅ All Cypress E2E specs passed

# [1.19.0](https://github.com/n8n-io/n8n/compare/n8n@1.18.0...n8n@1.19.0) (2023-11-29) ### Bug Fixes * **core:** Ensure member and admin cannot be promoted to owner ([#7830](#7830)) ([9b87a59](9b87a59)), closes [/linear.app/n8n/issue/PAY-985/add-user-role-modification-endpoint#comment-62355f6](https://github.com//linear.app/n8n/issue/PAY-985/add-user-role-modification-endpoint/issues/comment-62355f6) * **core:** Prevent error messages due to statistics about data loading ([#7824](#7824)) ([847f6ac](847f6ac)) * **core:** Tighten checks for multi-main setup usage ([#7788](#7788)) ([fdb2c18](fdb2c18)) * **core:** Use AbortController to notify nodes to abort execution ([#6141](#6141)) ([d2c18c5](d2c18c5)) * **editor:** Add telemetry to workflow history ([#7811](#7811)) ([d497041](d497041)) * **editor:** Allow owners and admins to share workflows and credentials they don't own ([#7833](#7833)) ([3ab3ec9](3ab3ec9)) * **editor:** Disable context menu actions in read-only mode ([#7789](#7789)) ([902beff](902beff)) * **editor:** Fix cloud plan data loading on instance ([#7841](#7841)) ([8b99384](8b99384)) * **editor:** Fix credential icon for old node type version ([#7843](#7843)) ([4074107](4074107)) * **editor:** Fix icon for unknown node type ([#7842](#7842)) ([28ac5a7](28ac5a7)) * **editor:** Fix mouse position in workflow previews ([#7853](#7853)) ([c063398](c063398)) * **editor:** Show nice error when environment is not set up ([#7778](#7778)) ([5835e05](5835e05)) * **editor:** Suppress dev server websocket messages in workflow view ([#7808](#7808)) ([685ffd7](685ffd7)) * **Google Sheets Node:** Read operation execute for each item ([#7800](#7800)) ([d548872](d548872)) * **HTTP Request Node:** Enable expressions for binary input data fields ([#7782](#7782)) ([6208af0](6208af0)) * **Microsoft SQL Node:** Prevent double escaping table name ([#7801](#7801)) ([73ec753](73ec753)) ### Features * Add AI tool building capabilities ([#7336](#7336)) ([87def60](87def60)) * Add initial scope checks via decorators ([#7737](#7737)) ([a37f1cb](a37f1cb)) * Ado 1296 spike credential setup in templates ([#7786](#7786)) ([aae45b0](aae45b0)) * **core:** Add Support for custom CORS origins for webhooks ([#7455](#7455)) ([99a9ea4](99a9ea4)) * **core:** Allow user role modification ([#7797](#7797)) ([7a86d36](7a86d36)) * **core:** Set up endpoint for all existing roles with license flag ([#7834](#7834)) ([2356fb0](2356fb0)) * **editor:** Add node name and version to NDV node settings ([#7731](#7731)) ([da85198](da85198)) * **editor:** Add routing middleware, permission checks, RBAC store, RBAC component ([#7702](#7702)) ([67a8891](67a8891)) * **editor:** Replace middleware for Role checks with Scope checks ([#7847](#7847)) ([72852a6](72852a6)) * **editor:** Show avatars for users currently working on the same workflow ([#7763](#7763)) ([77bc8ec](77bc8ec)) * **Notion Node:** Option to simplify output in getChildBlocks operation ([#7791](#7791)) ([d667bca](d667bca)) * **Slack Node:** Add support for getting the profile of a user ([#7829](#7829)) ([90bb6ba](90bb6ba)) Co-authored-by: ivov <ivov@users.noreply.github.com>

janober · 2023-12-01T14:46:12Z

Got released with n8n@1.19.4

feat: add routing middleware, rbac store, rbac component

ea4123a

alexgrozav added the n8n team Authored by the n8n team label Nov 14, 2023

alexgrozav requested a review from cstuncsik November 14, 2023 07:57

alexgrozav self-assigned this Nov 14, 2023

cstuncsik reviewed Nov 14, 2023

View reviewed changes

cstuncsik previously approved these changes Nov 14, 2023

View reviewed changes

alexgrozav added 2 commits November 14, 2023 14:29

test: add unit tests for rbac functionality

25bb007

feat: replace existing isAuthorized permissions check

0a334c2

alexgrozav dismissed cstuncsik’s stale review via 0a334c2 November 15, 2023 10:11

alexgrozav added 3 commits November 15, 2023 14:40

test: add tests for permission checks

f43648b

chore: merge master

21501ef

fix: fix /users route permission

e8b6123

alexgrozav changed the title ~~feat(editor): Add routing middleware, RBAC store, RBAC component~~ feat(editor): Add routing middleware, permission checks, RBAC store, RBAC component Nov 15, 2023

alexgrozav added 2 commits November 15, 2023 15:31

feat: code improvements and test coverage increase

659d93d

chore: add intermediary const

ebb6645

alexgrozav requested a review from cstuncsik November 15, 2023 13:36

alexgrozav added 2 commits November 15, 2023 15:41

fix: fix tag scope name

449a219

fix: remove .only

2be9594

alexgrozav commented Nov 15, 2023

View reviewed changes

cstuncsik previously approved these changes Nov 15, 2023

View reviewed changes

Merge remote-tracking branch 'origin/master' into pay-1005-front-end-…

14bc6f2

…permissions-overhaul

cstuncsik dismissed their stale review via 14bc6f2 November 16, 2023 14:13

cstuncsik added 3 commits November 16, 2023 18:09

Merge remote-tracking branch 'origin/master' into pay-1005-front-end-…

4229f24

…permissions-overhaul

Merge remote-tracking branch 'origin/master' into pay-1005-front-end-…

e77a9bd

…permissions-overhaul

fix: Update permission package

2e918c6

cstuncsik dismissed their stale review via b57306e November 20, 2023 15:40

cstuncsik and others added 9 commits November 20, 2023 16:52

fix: Remove unnecessary permission setting

edb3679

fix: Update variables view unit test

04f4c17

chore: merge master

5493903

feat: add init functions

6a6ffef

fix: Update permissions

e93c2f2

Merge branch 'pay-1005-front-end-permissions-overhaul' of github.com:…

0bd74d3

…n8n-io/n8n into pay-1005-front-end-permissions-overhaul

fix: Remove unused import

ddeeb25

fix: Add back user to variable view test

fdc3d09

fix: Roll back variable view changes

34eb0d2

cstuncsik previously approved these changes Nov 21, 2023

View reviewed changes

fix: Update permissions

6d7c77e

cstuncsik dismissed their stale review via 6d7c77e November 21, 2023 20:35

cstuncsik previously approved these changes Nov 21, 2023

View reviewed changes

fix: Permission object is not optional in test function

d403b14

cstuncsik dismissed their stale review via d403b14 November 22, 2023 05:45

cstuncsik previously approved these changes Nov 22, 2023

View reviewed changes

Merge remote-tracking branch 'origin/master' into pay-1005-front-end-…

1eba640

…permissions-overhaul

cstuncsik dismissed their stale review via 1eba640 November 23, 2023 11:06

cstuncsik approved these changes Nov 23, 2023

View reviewed changes

alexgrozav merged commit 67a8891 into master Nov 23, 2023
19 checks passed

alexgrozav deleted the pay-1005-front-end-permissions-overhaul branch November 23, 2023 11:22

github-actions bot mentioned this pull request Nov 29, 2023

🚀 Release 1.19.0 #7863

Merged

janober added the Released label Dec 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(editor): Add routing middleware, permission checks, RBAC store, RBAC component #7702

feat(editor): Add routing middleware, permission checks, RBAC store, RBAC component #7702

alexgrozav commented Nov 14, 2023

cstuncsik Nov 14, 2023 •

edited

Loading

alexgrozav Nov 15, 2023

cstuncsik Nov 14, 2023

alexgrozav Nov 15, 2023

cstuncsik Nov 14, 2023

alexgrozav Nov 15, 2023

cstuncsik left a comment

github-actions bot commented Nov 14, 2023

cypress bot commented Nov 14, 2023 •

edited

Loading

alexgrozav Nov 15, 2023

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 21, 2023

github-actions bot commented Nov 21, 2023

github-actions bot commented Nov 22, 2023

github-actions bot commented Nov 23, 2023

janober commented Dec 1, 2023

	valid = options.features.every((feature) => settingsStore.isEnterpriseFeatureEnabled(feature));
	valid = options.features.every(settingsStore.isEnterpriseFeatureEnabled);

feat(editor): Add routing middleware, permission checks, RBAC store, RBAC component #7702

feat(editor): Add routing middleware, permission checks, RBAC store, RBAC component #7702

Conversation

alexgrozav commented Nov 14, 2023

cstuncsik Nov 14, 2023 • edited Loading

Choose a reason for hiding this comment

alexgrozav Nov 15, 2023

Choose a reason for hiding this comment

cstuncsik Nov 14, 2023

Choose a reason for hiding this comment

alexgrozav Nov 15, 2023

Choose a reason for hiding this comment

cstuncsik Nov 14, 2023

Choose a reason for hiding this comment

alexgrozav Nov 15, 2023

Choose a reason for hiding this comment

cstuncsik left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 14, 2023

cypress bot commented Nov 14, 2023 • edited Loading

2 flaky tests on run #3000 ↗︎

Review all test suite changes for PR #7702 ↗︎

alexgrozav Nov 15, 2023

Choose a reason for hiding this comment

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 21, 2023

github-actions bot commented Nov 21, 2023

github-actions bot commented Nov 22, 2023

github-actions bot commented Nov 23, 2023

janober commented Dec 1, 2023

cstuncsik Nov 14, 2023 •

edited

Loading

cypress bot commented Nov 14, 2023 •

edited

Loading