New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Turn off executions list auto-refresh after leaving the page #8005
fix(editor): Turn off executions list auto-refresh after leaving the page #8005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen at least 3 PRs in the past to fix auto-refresh for the executions list. Maybe we should add an e2e test for this view, and prevent this regression from ever happening again?
## Summary > Describe what the PR does and how to test. Photos and videos are recommended. - Adds route name check - Adds further extensive tests ## Related tickets and issues > Include links to **Linear ticket** or Github issue or Community forum post. Important in order to close *automatically* and provide context to reviewers. https://linear.app/n8n/issue/PAY-1136/ui-keeps-switching-back-to-executions-tab ## Review / Merge checklist - [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [x] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [x] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. > A feature is not complete without tests.
stopAutoRefreshInterval() { | ||
if (this.autoRefreshTimeout) { | ||
clearTimeout(this.autoRefreshTimeout); | ||
this.autoRefreshTimeout = undefined; | ||
} | ||
clearTimeout(this.autoRefreshTimeout); | ||
this.autoRefreshTimeout = undefined; | ||
}, | ||
onDocumentVisibilityChange() { | ||
if (document.visibilityState === 'hidden') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps a task for another time, but we should move most of this duplicate code into a useAutoRefresh
composable, and use useDocumentVisibility
from vueuse instead.
Passing run #3337 ↗︎
Details:
Review all test suite changes for PR #8005 ↗︎ |
✅ All Cypress E2E specs passed |
* master: fix(editor): Turn off executions list auto-refresh after leaving the page (#8005) fix(editor): Show credential share info only to appropriate users (#8020) 🚀 Release 1.21.0 (#8019) fix(ActiveCampaign Node): Fix pagination issue when loading tags (#8017) feat(n8n Form Trigger Node): Improvements (#7571) fix(editor): Fix bug with node names with certain characters (#8013) feat(editor): Filter component + implement in If node (#7490) fix(Postgres Trigger Node): Increase manual trigger timeout from 30 to 60 seconds (#8015) fix(core): Prevent workflow history saving error from happening (#7812) fix(editor): Fix Webhook URL expansion icon (#8011) docs: Add aliases to compare datasets node (#8010) refactor(core): Add telemetry for RBAC roles (#7969) docs(editor): Change to Summarize icon and Advanced section description (no-changelog) (#8008) refactor(core): Introduce import service (no-changelog) (#8001) fix(Webhook Node): Do not create binary data when there is no data in the request (#8000) 🚀 Release 1.20.0 (#7940)
…page (#8005) ## Summary Fixes the bug when users leave the executions page but there is still an ongoing request for executions. --------- Co-authored-by: Alex Grozav <alex@grozav.com>
## [1.21.1](https://github.com/n8n-io/n8n/compare/n8n@1.21.0...n8n@1.21.1) (2023-12-15) ### Bug Fixes * **ActiveCampaign Node:** Fix pagination issue when loading tags ([#8017](#8017)) ([d661861](d661861)) * **core:** Initialize queue once in queue mode ([#8025](#8025)) ([b1c9c50](b1c9c50)) * **core:** Restore workflow ID during execution creation ([#8031](#8031)) ([2d16161](2d16161)), closes [/github.com//pull/8002/files#diff-c8cbb62ca9ab2ae45e5f565cd8c63fff6475809a6241ea0b90acc575615224](https://github.com//github.com/n8n-io/n8n/pull/8002/files/issues/diff-c8cbb62ca9ab2ae45e5f565cd8c63fff6475809a6241ea0b90acc575615224) * **editor:** Add back credential `use` permission ([#8023](#8023)) ([cf5c723](cf5c723)) * **editor:** Disable auto scroll and list size check when clicking on executions ([#7983](#7983)) ([99d1771](99d1771)) * **editor:** Show credential share info only to appropriate users ([#8020](#8020)) ([9933fce](9933fce)) * **editor:** Turn off executions list auto-refresh after leaving the page ([#8005](#8005)) ([b866a94](b866a94)) Co-authored-by: ivov <ivov@users.noreply.github.com>
Got released with |
# [1.22.0](https://github.com/n8n-io/n8n/compare/n8n@1.21.0...n8n@1.22.0) (2023-12-21) ### Bug Fixes * **core:** Close db connection gracefully when exiting ([#8045](#8045)) ([e69707e](e69707e)) * **core:** Consider timeout in shutdown an error ([#8050](#8050)) ([4cae976](4cae976)) * **core:** Do not display error when stopping jobless execution in queue mode ([#8007](#8007)) ([8e6b951](8e6b951)) * **core:** Fix shutdown if terminating before hooks are initialized ([#8047](#8047)) ([6ae2f5e](6ae2f5e)) * **core:** Handle multiple termination signals correctly ([#8046](#8046)) ([67bd8ad](67bd8ad)) * **core:** Initialize queue once in queue mode ([#8025](#8025)) ([53c0b49](53c0b49)) * **core:** Prevent axios from force setting a form-urlencoded content-type ([#8117](#8117)) ([bba9576](bba9576)) * **core:** Remove circular references before serializing executions in public API ([#8043](#8043)) ([989888d](989888d)) * **core:** Restore workflow ID during execution creation ([#8031](#8031)) ([c5e6ba8](c5e6ba8)) * **core:** Use relative imports for dynamic imports in SecurityAuditService ([#8086](#8086)) ([785bf99](785bf99)) * **core:** Stop binary data restoration from preventing execution from finishing ([#8082](#8082)) ([5ffff1b](5ffff1b)) * **editor:** Add back credential `use` permission ([#8023](#8023)) ([329e5bf](329e5bf)) * **editor:** Cleanup Executions page component ([#8053](#8053)) ([2689c37](2689c37)) * **editor:** Disable auto scroll and list size check when clicking on executions ([#7983](#7983)) ([fcb8b91](fcb8b91)) * **editor:** Ensure execution data overrides pinned data when copying in executions view ([#8009](#8009)) ([1d1cb0d](1d1cb0d)) * **editor:** Fix copy/paste issue when switch node is in workflow ([#8103](#8103)) ([4b86926](4b86926)) * **editor:** Make keyboard shortcuts more strict; don't accept extra Ctrl/Alt/Shift keys ([#8024](#8024)) ([8df49e1](8df49e1)) * **editor:** Show credential share info only to appropriate users ([#8020](#8020)) ([b29b4d4](b29b4d4)) * **editor:** Turn off executions list auto-refresh after leaving the page ([#8005](#8005)) ([e3c363d](e3c363d)) * **editor:** Update image sizes in template description not to be full width always ([#8037](#8037)) ([63a6e7e](63a6e7e)) * **ActiveCampaign Node:** Fix pagination issue when loading tags ([#8017](#8017)) ([1943857](1943857)) * **HTTP Request Node:** Do not create circular references in HTTP request node output ([#8030](#8030)) ([5b7ea16](5b7ea16)) * Upgrade axios to address CVE-2023-45857 ([#7713](#7713)) ([64eb9bb](64eb9bb)) ### Features * Add option to `returnIntermediateSteps` for AI agents ([#8113](#8113)) ([7806a65](7806a65)) * **core:** Add config option to prefer GET request over LIST when using Hashicorp Vault ([#8049](#8049)) ([439a22d](439a22d)) * **core:** Add N8N_GRACEFUL_SHUTDOWN_TIMEOUT env var ([#8068](#8068)) ([614f488](614f488)) * **editor:** Add lead enrichment suggestions to workflow list ([#8042](#8042)) ([36a923c](36a923c)) * **editor:** Finalize workers view ([#8052](#8052)) ([edfa784](edfa784)) * **editor:** Gracefully ignore invalid payloads in postMessage handler ([#8096](#8096)) ([9d22c7a](9d22c7a)) * **editor:** Upgrade frontend tooling to address a few vulnerabilities ([#8100](#8100)) ([19b7f1f](19b7f1f)) * **Filter Node:** Overhaul UI by adding the new filter component ([#8016](#8016)) ([3d53052](3d53052)) * **Respond to Webhook Node:** Overhaul with improvements like returning all items ([#8093](#8093)) ([32d397e](32d397e)) ### Performance Improvements * **editor:** Improve canvas rendering performance ([#8022](#8022)) ([b780436](b780436)) Co-authored-by: ivov <ivov@users.noreply.github.com>
Summary
Fixes the bug when users leave the executions page but there is still an ongoing request for executions.