refactor(core): Warn on sqlite DB detected during init on queue mode #8034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
tomi
reviewed
Dec 15, 2023
netroy
reviewed
Dec 15, 2023
ivov
changed the title
I usually run sqlite locally for testing and it works, it's worth haviing a warning and adding it to |
ivov
changed the title
netroy
approved these changes
Dec 15, 2023
1 flaky test on run #3349 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Screenshots
Video
|
|
Review all test suite changes for PR #8034 ↗︎
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Dec 15, 2023
* master: refactor(core): Warn on sqlite DB detected during init on queue mode (#8034) docs: Two small UI copy fixes in sub-nodes (#8032) fix(core): Restore workflow ID during execution creation (#8031) fix(core): Initialize queue once in queue mode (#8025) fix(editor): Add back credential `use` permission (#8023) fix(editor): Disable auto scroll and list size check when clicking on executions (#7983) fix(editor): Fix dialogVisibleChanged hooks event when meta.value is undefined (no-changelog) (#7986) perf(editor): Improve canvas rendering performance (#8022)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up queue mode, it is easy to overlook that not exporting Postgres env vars will default the worker to use sqlite, which will fail during execution with a non-obvious error. Hence add warnings when starting a worker with an incompatible DB type.