Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Pipedrive Node): Add sort field for get all persons #8138

Merged
merged 3 commits into from
Jun 20, 2024
Merged

feat(Pipedrive Node): Add sort field for get all persons #8138

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38cfac0
feat(pipedrive): include sort field in pipedrive get all persons
daniel-alba17 Dec 21, 2023
0f1d78d
Merge branch 'master' into Feat/Include-sort-field-in-pipedrive
daniel-alba17 Apr 29, 2024
cf56e67
Merge branch 'master' into Feat/Include-sort-field-in-pipedrive
daniel-alba17 Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/nodes-base/nodes/Pipedrive/Pipedrive.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3515,6 +3515,14 @@ export class Pipedrive implements INodeType {
description:
'If supplied, only persons whose name starts with the specified letter will be returned',
},
{
displayName: 'Sort',
name: 'sort',
type: 'string',
default: '',
description:
'The field names and sorting mode separated by a comma (field_name_1 ASC, field_name_2 DESC). Only first-level field keys are supported (no nested keys).',
},
],
},

Expand Down Expand Up @@ -4801,6 +4809,10 @@ export class Pipedrive implements INodeType {
qs.first_char = additionalFields.firstChar as string;
}

if (additionalFields.sort) {
qs.sort = additionalFields.sort as string;
}

endpoint = '/persons';
} else if (operation === 'search') {
// ----------------------------------
Expand Down