fix(core): Report when waitTill is invalid and handle it #8356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
approved these changes
Jan 17, 2024
2 flaky tests on run #3796 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
29-templates.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Templates > should save template id with the workflow |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8356 ↗︎
|
✅ All Cypress E2E specs passed |
netroy
changed the title
netroy
changed the title
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Executions sometimes fail to resume with the issue
execution.waitTill.getTime is not a function. Since we cannot reproduce it locally, this attempts to patch it temporarily until we identify the source.Related tickets and issues
https://n8nio.sentry.io/issues/4703277858/?project=4503924908883968
https://community.n8n.io/t/wait-does-not-work-after-65-seconds/34776
#6624
#8136
https://linear.app/n8n/issue/PAY-1173/bug-waiting-executions-failing-to-resume
Review / Merge checklist
(no-changelog)otherwise. (conventions)