feat(core): Upgrade oclif (no-changelog) #8381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
changed the title
|
|
1 similar comment
|
|
tomi
previously approved these changes
Jan 19, 2024
|
|
2 flaky tests on run #3869 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should retrieve remote options when non-required params throw errors |
Test Replay
Screenshots
Video
|
|
28-debug.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Debug > should be able to debug executions |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8381 ↗︎
tomi
approved these changes
Jan 22, 2024
|
✅ All Cypress E2E specs passed |
|
Got released with |
This was referenced Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oclif 1.x has long been deprecated, and should not be used anymore.
PS: This removes the manifest generation, because to generate the manifest, we need to add the
oclifpackage, which pulls in quite a lot of sub-dependencies.I benchmarked the startup performance with and without the manifest file, and didn't notice any difference significant enough to justify maintaining the additional bloat.
If we really do want to keep the manifest around, we can instead copy that command into the repo, and avoid pulling in a few hundred new dependencies.
Review / Merge checklist