fix(editor): Use web native <a> element in nav menus #8385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently all navigation in the menus is done programmatically. This is not accessible way to do navigation, as it prevents browser default behaviour, like cmd/ctrl+click to open into new tab. Also screen readers don't give any indication that the active element is an anchor. This PR refactors component library's Menu and MenuItem to use either vue-router RouterLink or <a> when the menu item is a navigation element.
tomi
commented
Jan 18, 2024
| :content="item.secondaryIcon?.tooltip?.content" | ||
| :disabled="compact || !item.secondaryIcon?.tooltip?.content" | ||
| :show-after="tooltipDelay" | ||
| <ConditionalRouterLink v-bind="item.route ?? item.link"> |
There was a problem hiding this comment.
The diff is a bit messed. This was added as a wrapper
tomi
force-pushed
the
ado-35-bug-should-be-able-to-open-views-in-new-navigation-tab
branch
from
67fd89b
to
f1cd098
Compare
n8n-assistant
bot
added
n8n team
1 task
cstuncsik
approved these changes
Jan 19, 2024
1 flaky test on run #3833 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sharing > should work for admin role on credentials created by others (also can share it with themselves) |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8385 ↗︎
|
✅ All Cypress E2E specs passed |
tomi
deleted the
ado-35-bug-should-be-able-to-open-views-in-new-navigation-tab
branch
ivov
pushed a commit
that referenced
this pull request
Jan 22, 2024
Merged
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently all navigation in the menus is done programmatically. This is not accessible way to do navigation, as it prevents browser default behaviour, like cmd/ctrl+click to open into new tab. Also screen readers don't give any indication that the active element is an anchor.
This PR refactors component library's Menu and MenuItem to use either vue-router RouterLink or when the menu item is a navigation element.
Kapture.2024-01-18.at.14.17.57.mp4
Related tickets and issues
https://linear.app/n8n/issue/ADO-35/bug-should-be-able-to-open-views-in-new-navigation-tab
Review / Merge checklist
(no-changelog)otherwise. (conventions)