Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Enable ctrl/cmd click in workflow editor header #8387

Merged

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Jan 18, 2024

Summary

Follow-up to #8385

Open new tab if user cmd/ctrl clicks workflow editor header tabs.

Kapture.2024-01-18.at.16.04.35.mp4

Related tickets and issues

https://linear.app/n8n/issue/ADO-1723/fix-wf-executions-to-work-with-cmdclick-and-right-click

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 18, 2024
@alexgrozav alexgrozav self-requested a review January 19, 2024 11:53
Copy link
Member

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works as expected.

Copy link

cypress bot commented Jan 19, 2024

Passing run #3838 ↗︎

0 336 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Project: n8n Commit: d1121733ab
Status: Passed Duration: 03:23 💡
Started: Jan 19, 2024 12:01 PM Ended: Jan 19, 2024 12:04 PM

Review all test suite changes for PR #8387 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@tomi tomi merged commit e43cf2f into master Jan 19, 2024
29 checks passed
@tomi tomi deleted the ado-1723-fix-wf-executions-to-work-with-cmdclick-and-right-click branch January 19, 2024 12:28
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
@janober
Copy link
Member

janober commented Jan 22, 2024

Got released with n8n@1.25.1

@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants