Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Open executions with large number of execution items #8423

Merged
merged 6 commits into from
Jan 29, 2024
Merged

fix(editor): Open executions with large number of execution items #8423

merged 6 commits into from
Jan 29, 2024

Conversation

mutdmour
Copy link
Contributor

@mutdmour mutdmour commented Jan 23, 2024 •
edited

Summary

Skip paired item mapping on the UI if workflow execution is too large.

Related tickets and issues

https://linear.app/n8n/issue/ADO-1611/manually-executing-workflow-crashes-the-fe-and-loading-the-past
https://community.n8n.io/t/viewing-execution-in-chrome-causes-chrome-to-crash/32695/
https://community.n8n.io/t/workflow-executions-page-keeps-crashing/34581/

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 23, 2024
@mutdmour mutdmour changed the title fix: Open executions with large execution data fix: Open executions with large number of execution items Jan 25, 2024
tomi
tomi previously approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job adding tests 👏 One small comment about readability and perf.

packages/editor-ui/src/utils/__tests__/pairedItemUtils.test.ts Show resolved Hide resolved
packages/editor-ui/src/utils/pairedItemUtils.ts Outdated Show resolved Hide resolved
@cypress Cypress
Copy link

cypress bot commented Jan 25, 2024 •
edited

Passing run #3944 ↗︎

0 338 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Project: n8n Commit: c1398e804b
Status: Passed Duration: 03:19 💡
Started: Jan 29, 2024 7:56 AM Ended: Jan 29, 2024 7:59 AM

Review all test suite changes for PR #8423 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@mutdmour @tomi
Update packages/editor-ui/src/utils/pairedItemUtils.ts
c1398e8 
Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@mutdmour mutdmour merged commit 56da2e4 into master Jan 29, 2024
28 checks passed
@mutdmour mutdmour deleted the ado-1611 branch January 29, 2024 08:33
@github-actions github-actions bot mentioned this pull request Jan 31, 2024
Merged
@netroy netroy changed the title fix: Open executions with large number of execution items fix(editor): Open executions with large number of execution items Jan 31, 2024
@janober
Copy link
Member

janober commented Feb 2, 2024

Got released with n8n@1.27.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomi tomi tomi approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mutdmour @janober @tomi