Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Use correct node version when pasting/importing nodes #8456

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Jan 26, 2024

Summary

Pasting or importing nodes should work for old node versions. Testing notes in linear.

Related tickets and issues

https://linear.app/n8n/issue/NODE-1080/v2-switch-node-cant-be-pasted-into-workflows

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 26, 2024
Copy link

cypress bot commented Jan 26, 2024

1 flaky test on run #3936 ↗︎

0 338 5 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: dfc5fe440e
Status: Passed Duration: 03:26 💡
Started: Jan 26, 2024 1:47 PM Ended: Jan 26, 2024 1:50 PM
Flakiness  cypress/e2e/19-execution.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Execution > should test manual workflow stop Test Replay Screenshots Video

Review all test suite changes for PR #8456 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit 70af67e into master Jan 26, 2024
28 checks passed
@elsmr elsmr deleted the node-1080-v2-switch-node-cant-be-pasted-into-workflows branch January 26, 2024 14:09
@github-actions github-actions bot mentioned this pull request Jan 31, 2024
@netroy netroy changed the title fix: Use correct node version when pasting/importing nodes fix(editor): Use correct node version when pasting/importing nodes Jan 31, 2024
@janober
Copy link
Member

janober commented Feb 2, 2024

Got released with n8n@1.27.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants