Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Update follow-redirects to address CVE-2024-28849 #8902

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Mar 15, 2024

GH Advisory

Review / Merge checklist

  • PR title and summary are descriptive

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 15, 2024
krynble
krynble previously approved these changes Mar 15, 2024
Copy link

cypress bot commented Mar 15, 2024

2 flaky tests on run #4399 ↗︎

0 343 12 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: d49c4475e0
Status: Passed Duration: 03:48 💡
Started: Mar 15, 2024 4:00 PM Ended: Mar 15, 2024 4:04 PM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #8902 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit a10120f into master Mar 15, 2024
28 checks passed
@netroy netroy deleted the fix-CVE-2024-28849 branch March 15, 2024 16:07
@github-actions github-actions bot mentioned this pull request Mar 20, 2024
@janober
Copy link
Member

janober commented Mar 20, 2024

Got released with n8n@1.34.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants