Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Add examples for Luxon DateTime expression methods #9361

Merged
merged 13 commits into from
May 16, 2024
Merged

feat(editor): Add examples for Luxon DateTime expression methods #9361

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e0883f7
Add diffTo and diffToNow
elsmr Apr 25, 2024
38fee9b
Add Luxon descriptions/examples
elsmr Apr 26, 2024
d18efd4
Tweak docs
elsmr May 10, 2024
8b5c421
Make links external
elsmr May 10, 2024
79df5d2
Merge branch 'master' into node-1312-add-examples-for-luxon-datetime-…
elsmr May 14, 2024
3809cb7
Make argument optional
elsmr May 15, 2024
cff50e9
Fix review remarks
elsmr May 15, 2024
518e37c
Fix evaluated DateTime format
elsmr May 15, 2024
34142f8
Apply suggestions from code review
elsmr May 16, 2024
c55c77b
Improve expression output for Date/DateTime
elsmr May 16, 2024
86d355a
Use infobox renderer in Luxon completions in Code node
elsmr May 16, 2024
ec39ee9
Tweak DateTime example evaluation format
elsmr May 16, 2024
35504c8
Shorter wording
elsmr May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/editor-ui/src/plugins/codemirror/completions/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ export const STRING_RECOMMENDED_OPTIONS = [
'length',
];

export const LUXON_RECOMMENDED_OPTIONS = ['format()', 'minus()', 'plus()', 'diff()', 'extract()'];
export const LUXON_RECOMMENDED_OPTIONS = ['format()', 'minus()', 'plus()', 'diffTo()', 'extract()'];
elsmr marked this conversation as resolved.
Show resolved Hide resolved
export const OBJECT_RECOMMENDED_OPTIONS = ['keys()', 'values()', 'isEmpty()', 'hasField()'];
export const ARRAY_RECOMMENDED_OPTIONS = ['length', 'last()', 'includes()', 'map()', 'filter()'];
export const ARRAY_NUMBER_ONLY_METHODS = ['max()', 'min()', 'sum()', 'average()'];
Expand Down
7 changes: 1 addition & 6 deletions packages/editor-ui/src/plugins/codemirror/completions/datatype.completions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,6 @@ export const luxonInstanceOptions = ({
name: key,
isFunction,
docs: luxonInstanceDocs,
translations: i18n.luxonInstance,
includeHidden,
transformLabel,
}) as Completion;
Expand All @@ -778,7 +777,6 @@ export const luxonStaticOptions = () => {
name: key,
isFunction: true,
docs: luxonStaticDocs,
translations: i18n.luxonStatic,
}) as Completion;
})
.filter(Boolean),
Expand All @@ -788,14 +786,12 @@ export const luxonStaticOptions = () => {
const createLuxonAutocompleteOption = ({
name,
docs,
translations,
isFunction = false,
includeHidden = false,
transformLabel = (label) => label,
}: {
name: string;
docs: NativeDoc;
translations: Record<string, string | undefined>;
isFunction?: boolean;
includeHidden?: boolean;
transformLabel?: (label: string) => string;
Expand Down Expand Up @@ -835,8 +831,7 @@ const createLuxonAutocompleteOption = ({
option.info = createCompletionOption({
name,
isFunction,
// Add translated description
doc: { ...doc, description: translations[name] } as DocMetadata,
doc,
transformLabel,
}).info;
return option;
Expand Down
Loading
Loading