fix(core): Upgrade sheetjs to address CVE-2024-22363 #9498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
force-pushed
the
fix-CVE-2024-22363
branch
from
d03c71b
to
b118cc9
Compare
despairblue
approved these changes
May 23, 2024
| @@ -109,7 +113,7 @@ describe('Execute Spreadsheet File Node', () => { | |||
| mimeType: 'text/html', | |||
| fileType: 'html', | |||
| fileExtension: 'html', | |||
| data: 'PGh0bWw+PGhlYWQ+PG1ldGEgY2hhcnNldD0idXRmLTgiLz48dGl0bGU+U2hlZXRKUyBUYWJsZSBFeHBvcnQ8L3RpdGxlPjwvaGVhZD48Ym9keT48dGFibGU+PHRyPjx0ZCBkYXRhLXQ9InMiIGRhdGEtdj0iQSIgaWQ9InNqcy1BMSI+QTwvdGQ+PHRkIGRhdGEtdD0icyIgZGF0YS12PSJCIiBpZD0ic2pzLUIxIj5CPC90ZD48dGQgZGF0YS10PSJzIiBkYXRhLXY9IkMiIGlkPSJzanMtQzEiPkM8L3RkPjwvdHI+PHRyPjx0ZCBkYXRhLXQ9Im4iIGRhdGEtdj0iMSIgaWQ9InNqcy1BMiI+MTwvdGQ+PHRkIGRhdGEtdD0ibiIgZGF0YS12PSIyIiBpZD0ic2pzLUIyIj4yPC90ZD48dGQgZGF0YS10PSJuIiBkYXRhLXY9IjMiIGlkPSJzanMtQzIiPjM8L3RkPjwvdHI+PHRyPjx0ZCBkYXRhLXQ9Im4iIGRhdGEtdj0iNCIgaWQ9InNqcy1BMyI+NDwvdGQ+PHRkIGRhdGEtdD0ibiIgZGF0YS12PSI1IiBpZD0ic2pzLUIzIj41PC90ZD48dGQgZGF0YS10PSJuIiBkYXRhLXY9IjYiIGlkPSJzanMtQzMiPjY8L3RkPjwvdHI+PC90YWJsZT48L2JvZHk+PC9odG1sPg==', | |||
| data: readBinaryFile('spreadsheet.html'), | |||
There was a problem hiding this comment.
This is soo much better 😻
3 flaky tests on run #5112 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 2 flaky tests
Review all test suite changes for PR #9498 ↗︎
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
May 24, 2024
* master: refactor(core): Use consistent CSRF state validation across oAuth controllers (#9104) feat(core): Print the name of the migration that cannot be reverted when using `n8n db:revert` (#9473) fix(editor): Hard load after logout to reset stores (no-changelog) (#9500) refactor(core): Stop reporting `EAUTH` error codes to Sentry (no-changelog) (#9496) fix(core): Upgrade sheetjs to address CVE-2024-22363 (#9498) refactor: Remove skipped tests (no-changelog) (#9497) feat(editor): Add initial code for NodeView and Canvas rewrite (no-changelog) (#9135) fix(editor): Show input panel with not connected message (#9495) fix(editor): Prevent XSS in node-issues tooltip (#9490) # Conflicts: # pnpm-lock.yaml
RicardoE105
pushed a commit
that referenced
this pull request
May 24, 2024
Merged
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advisory
Related tickets and issues
https://community.n8n.io/t/1c2h-vulnerabilties-in-the-docker/46296
Review / Merge checklist