-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Properly update workflow info in main header #9789
fix(editor): Properly update workflow info in main header #9789
Conversation
…can-lose-workflows-when-saving-from-executions
…can-lose-workflows-when-saving-from-executions # Conflicts: # packages/editor-ui/src/components/MainHeader/MainHeader.vue
…execution view route component
4 flaky tests on run #5647 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
10-undo-redo.cy.ts • 2 flaky tests
Test | Artifacts | |
---|---|---|
Undo/Redo > should undo/redo adding connected nodes |
Test Replay
Screenshots
Video
|
|
Undo/Redo > should undo/redo renaming node using NDV |
Test Replay
Screenshots
Video
|
Review all test suite changes for PR #9789 ↗︎
…can-lose-workflows-when-saving-from-executions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Small remark.
|
|
✅ All Cypress E2E specs passed |
✅ All Cypress E2E specs passed |
…can-lose-workflows-when-saving-from-executions
|
3 similar comments
|
|
|
✅ All Cypress E2E specs passed |
Got released with |
Summary
Workflow tags and name occasionally lost the correct value when saving and switching between editor and executions tab.
Also a hard refresh enables workflow Save button which removed all data when clicked.
Related Linear tickets, Github issues, and Community forum posts
PAY-1684
#9706
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)