Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Properly update workflow info in main header #9789

Conversation

cstuncsik
Copy link
Contributor

@cstuncsik cstuncsik commented Jun 18, 2024

Summary

Workflow tags and name occasionally lost the correct value when saving and switching between editor and executions tab.
Also a hard refresh enables workflow Save button which removed all data when clicked.

Related Linear tickets, Github issues, and Community forum posts

PAY-1684
#9706

Review / Merge checklist

  • PR title and summary are descriptive.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jun 18, 2024
…can-lose-workflows-when-saving-from-executions

# Conflicts:
#	packages/editor-ui/src/components/MainHeader/MainHeader.vue
Copy link

cypress bot commented Jun 19, 2024

4 flaky tests on run #5647 ↗︎

0 395 0 0 Flakiness 4

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project: n8n Commit: d4c5d41c2a
Status: Passed Duration: 05:13 💡
Started: Jun 24, 2024 12:38 PM Ended: Jun 24, 2024 12:43 PM
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  10-undo-redo.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding connected nodes Test Replay Screenshots Video
Undo/Redo > should undo/redo renaming node using NDV Test Replay Screenshots Video

Review all test suite changes for PR #9789 ↗︎

…can-lose-workflows-when-saving-from-executions
alexgrozav
alexgrozav previously approved these changes Jun 20, 2024
Copy link
Contributor

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Small remark.

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@alexgrozav alexgrozav self-requested a review June 20, 2024 12:52
alexgrozav
alexgrozav previously approved these changes Jun 20, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

alexgrozav
alexgrozav previously approved these changes Jun 21, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav self-requested a review June 21, 2024 15:40
alexgrozav
alexgrozav previously approved these changes Jun 21, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

alexgrozav
alexgrozav previously approved these changes Jun 24, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

3 similar comments
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@krynble krynble added the release/backport Changes that need to be backported to older releases. label Jun 24, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 1ba656e into master Jun 24, 2024
47 checks passed
@cstuncsik cstuncsik deleted the pay-1684-bug-users-can-lose-workflows-when-saving-from-executions branch June 24, 2024 13:08
@github-actions github-actions bot mentioned this pull request Jun 26, 2024
@janober
Copy link
Member

janober commented Jun 26, 2024

Got released with n8n@1.47.1

@github-actions github-actions bot mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants