Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Chat Trigger Node): Add support for file uploads & harmonize public and development chat #9802

Merged
merged 52 commits into from
Jul 9, 2024
Merged

feat(Chat Trigger Node): Add support for file uploads & harmonize public and development chat #9802

merged 52 commits into from
Jul 9, 2024

Conversation

OlegIvaniv
Copy link
Contributor

@OlegIvaniv OlegIvaniv commented Jun 19, 2024 •
edited
Loading

Summary

  • Implemented support for file uploads in @n8n/chat.
  • Refactored the WorkflowLMChat editor-ui component to use the chat SDK
  • Improved markdown code rendering in chat messages and added support for highlight.js
  • Implemented Load All Input Data for binary data loader
CleanShot.2024-07-03.at.13.08.05.mp4

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@OlegIvaniv
WIP: Chat file uploads
214ccb8 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
File file reset
aa7f15e 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Merge branch 'master' into ai-190-add-file-upload-to-chat-trigger
d520aed
@OlegIvaniv
Implement allInputData binary mode
a204a18 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Merge branch 'master' into ai-190-add-file-upload-to-chat-trigger
5a5d0e8
@OlegIvaniv
WIP: Implement file upload for Workflow LM Chat
7946100 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Fix memory auto sessionId, markdown rendering, improve dark mode corr…
8d293d3 
…ectly handle non-multiform requests

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Merge branch 'master' into ai-190-add-file-upload-to-chat-trigger
96f9f4a
@OlegIvaniv
Remove debugging console.logs
1969984 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Fix TS error
a9d5abb 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jun 19, 2024
@OlegIvaniv
Cleanup
dfc66ba 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Improve theme
9317b64 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv OlegIvaniv force-pushed the ai-190-add-file-upload-to-chat-trigger branch from 31b62f5 to 9317b64 Compare June 19, 2024 10:13
@OlegIvaniv
Update public chat package version import
390246b 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Improve styles
be568e8 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Clean-up and refactor message actions
6e3b2d7 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Remove unused component
3bcf8b6 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Bump chat sdk version
f4ffda4 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Fix binary data in filesystem mode
264225e 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Fix unit tests
6ca7945 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Merge branch 'master' into ai-190-add-file-upload-to-chat-trigger
484ba19
@OlegIvaniv
fix: Improve scrolling and prevent files resetting when selecting
bb3ee1b 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Merge branch 'master' into ai-190-add-file-upload-to-chat-trigger
c325763
@OlegIvaniv
Fix linting issues
64a1254 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Design improvements
b908416 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Merge branch 'master' into ai-190-add-file-upload-to-chat-trigger
661dd93
@OlegIvaniv
Fix past messages cycling if there’s only a single message
66e18c0 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Reset previousMessageIndex sooner
35a757b 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Fix chat file name & use method for file handler
3953056 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Fix linting issue
e38400e 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Merge branch 'master' into ai-190-add-file-upload-to-chat-trigger
e320b3e
@OlegIvaniv
Remove eslint 9.4 from pnpm-lock
d06b6ed 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
debugging linting
ce68a06 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv
Cleanup pnpm-lock
571f18f 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@alexgrozav alexgrozav self-requested a review July 8, 2024 14:15
alexgrozav
alexgrozav approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

alexgrozav
alexgrozav previously approved these changes Jul 9, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@OlegIvaniv
Update @vueuse to 10.11.0 to fix issues with onClickOutside directive
0f7ee05 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@alexgrozav alexgrozav self-requested a review July 9, 2024 09:30
@OlegIvaniv
Fix useClipboard spec
43c88f1 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv OlegIvaniv force-pushed the ai-190-add-file-upload-to-chat-trigger branch from b55791e to 43c88f1 Compare July 9, 2024 10:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

✅ All Cypress E2E specs passed

@netroy netroy mentioned this pull request Jul 9, 2024
Merged
2 tasks
@OlegIvaniv OlegIvaniv merged commit df78315 into master Jul 9, 2024
27 checks passed
@OlegIvaniv OlegIvaniv deleted the ai-190-add-file-upload-to-chat-trigger branch July 9, 2024 11:45
This was referenced Jul 10, 2024
Merged
Merged
Merged
Merged
@janober
Copy link
Member

janober commented Jul 10, 2024

Got released with n8n@1.50.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-radency michael-radency michael-radency left review comments

@alexgrozav alexgrozav alexgrozav approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OlegIvaniv @michael-radency @janober @alexgrozav