Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade to TypeScript 5.5 (no-changelog) #9828

Merged
merged 6 commits into from
Jun 24, 2024
Merged

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jun 21, 2024

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jun 21, 2024
@ivov ivov marked this pull request as draft June 21, 2024 08:41
@ivov ivov marked this pull request as ready for review June 24, 2024 15:28
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link

cypress bot commented Jun 24, 2024

2 flaky tests on run #5654 ↗︎

0 395 0 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: 0d850bac68
Status: Passed Duration: 04:14 💡
Started: Jun 24, 2024 3:39 PM Ended: Jun 24, 2024 3:43 PM
Flakiness  10-undo-redo.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding nodes Test Replay Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #9828 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit e33a473 into master Jun 24, 2024
26 checks passed
@ivov ivov deleted the upgrade-typescript-5.5 branch June 24, 2024 15:50
@janober
Copy link
Member

janober commented Jun 27, 2024

Got released with n8n@1.48.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants