Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Centralize scaling mode (no-changelog) #9835

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jun 21, 2024

No description provided.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jun 21, 2024
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General direction is looking good.

I was thinking if we could leverage ActiveExecutions' existing functionality as part of the Worker.ts's runningJobsSummary but that could be just an enhancement for the future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we can get rid of all the watchdog functionality

Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do this in 2 parts:

  • part 1 should be the refactor that reorganizes most of our existing code in packages/cli/src/scaling-mode in a way that we can also add lots of unit tests for
  • part 2 is when we actually make the switch. This should be in v2.

It's entirely possible that we might be able to address some of the issues without the bullmq upgrade, by simply moving away from the super-entangled code that the current worker stuff is.

@ivov ivov changed the title refactor(core)!: Upgrade scaling mode to bullmq refactor(core) Centralize scaling mode (no-changelog) Jul 5, 2024
@ivov ivov changed the title refactor(core) Centralize scaling mode (no-changelog) refactor(core): Centralize scaling mode (no-changelog) Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants