-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): Centralize scaling mode (no-changelog) #9835
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General direction is looking good.
I was thinking if we could leverage ActiveExecutions
' existing functionality as part of the Worker.ts's runningJobsSummary
but that could be just an enhancement for the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully we can get rid of all the watchdog functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should do this in 2 parts:
- part 1 should be the refactor that reorganizes most of our existing code in
packages/cli/src/scaling-mode
in a way that we can also add lots of unit tests for - part 2 is when we actually make the switch. This should be in v2.
It's entirely possible that we might be able to address some of the issues without the bullmq upgrade, by simply moving away from the super-entangled code that the current worker stuff is.
bullmq
No description provided.