-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Disable Fast Fallback for network connections (no-changelog) #9860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
5 flaky tests on run #5675 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
Undo/Redo > should undo/redo adding nodes |
Test Replay
Screenshots
Video
|
|
Undo/Redo > should undo/redo adding connected nodes |
Test Replay
Screenshots
Video
|
Review all test suite changes for PR #9860 ↗︎
✅ All Cypress E2E specs passed |
Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com>
✅ All Cypress E2E specs passed |
…g) (#9860) Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com>
Got released with |
Hey @janober , does Deborah (https://community.n8n.io/u/deborah/summary) have a GitHub user account to ping? The reason I ask, is because she had a community post not long ago asking for how the n8n documentation can be improved. I would argue this PR is Exhibit A of what absolutely needs to be included in the Release Notes here: For those n8n community users who want to upgrade regularly:
To minimize this recurring pain for users, could these sorts of breaking issues be called out directly either in the 1.47.1 release notes OR in the earlier 1.46.0 release notes -- something like a warning of: WARNING: If you are upgrading to 1.46.0, we strongly recommend you upgrade to 1.47.1 because of this issue... etc... Again, having some sort of PR tag to like Thanks for your time. |
Summary
Node.js 20 enabled Happy Eyeballs algorithm for all dual-stack network calls by default.
This has turned out to be an issue with certain services like Telegram and Airtable, that are not responding to their IPv6 addresses in a timely manner.
There have been a couple of fixes to Node's implementation of this algorithm, but there seem to be still some bugs present for our users.
Until one of us understand this issue a bit more, and can track the issues on Node.js, I suggest that we disable socket
autoSelectFamily
by default, like it used to be on Node.js 18.Related Linear tickets, Github issues, and Community forum posts
https://community.n8n.io/t/errors-since-last-n8n-update-1-44-1/48238
#9824
Review / Merge checklist