Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Disable Fast Fallback for network connections (no-changelog) #9860

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Jun 25, 2024

Summary

Node.js 20 enabled Happy Eyeballs algorithm for all dual-stack network calls by default.
This has turned out to be an issue with certain services like Telegram and Airtable, that are not responding to their IPv6 addresses in a timely manner.
There have been a couple of fixes to Node's implementation of this algorithm, but there seem to be still some bugs present for our users.
Until one of us understand this issue a bit more, and can track the issues on Node.js, I suggest that we disable socket autoSelectFamily by default, like it used to be on Node.js 18.

Related Linear tickets, Github issues, and Community forum posts

https://community.n8n.io/t/errors-since-last-n8n-update-1-44-1/48238
#9824

Review / Merge checklist

  • PR title and summary are descriptive

@netroy netroy added the release/backport Changes that need to be backported to older releases. label Jun 25, 2024
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jun 25, 2024
tomi
tomi previously approved these changes Jun 26, 2024
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

packages/cli/bin/n8n Outdated Show resolved Hide resolved
Copy link

cypress bot commented Jun 26, 2024

5 flaky tests on run #5675 ↗︎

0 395 0 0 Flakiness 5

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 10008c311f
Status: Passed Duration: 05:21 💡
Started: Jun 26, 2024 8:29 AM Ended: Jun 26, 2024 8:34 AM
Flakiness  5-ndv.cy.ts • 3 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > should retrieve remote options when non-required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  10-undo-redo.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding nodes Test Replay Screenshots Video
Undo/Redo > should undo/redo adding connected nodes Test Replay Screenshots Video

Review all test suite changes for PR #9860 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com>
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit df9cd89 into master Jun 26, 2024
27 checks passed
@netroy netroy deleted the disable-socket-autoSelect branch June 26, 2024 08:38
netroy added a commit that referenced this pull request Jun 26, 2024
…g) (#9860)

Co-authored-by: Tomi Turtiainen <10324676+tomi@users.noreply.github.com>
@janober
Copy link
Member

janober commented Jun 26, 2024

Got released with n8n@1.47.1

@dkindlund
Copy link

Hey @janober , does Deborah (https://community.n8n.io/u/deborah/summary) have a GitHub user account to ping?

The reason I ask, is because she had a community post not long ago asking for how the n8n documentation can be improved.

I would argue this PR is Exhibit A of what absolutely needs to be included in the Release Notes here:
https://docs.n8n.io/release-notes/#n8n1471

For those n8n community users who want to upgrade regularly:

  • they will likely upgrade to n8n@1.46.0 (which is currently marked as "latest" at the time of this post)
  • then, they'll get bitten by this bug in the PR
  • hunt through the forums, issue tracker, and PR to figure out why things broke
  • and then re-upgrade to n8n@1.47.1 (pre-release) (again)

To minimize this recurring pain for users, could these sorts of breaking issues be called out directly either in the 1.47.1 release notes OR in the earlier 1.46.0 release notes -- something like a warning of:

WARNING: If you are upgrading to 1.46.0, we strongly recommend you upgrade to 1.47.1 because of this issue... etc...

Again, having some sort of PR tag to likerelease/update-note-needed (or something like that) may be a good mechanism to notify Deborah about these sorts of issues in a consistent manner.

Thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants