Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BadInputs cause unexpected behavior #210

Closed
kulgg opened this issue May 4, 2021 · 1 comment · Fixed by #217
Closed

BadInputs cause unexpected behavior #210

kulgg opened this issue May 4, 2021 · 1 comment · Fixed by #217
Assignees
@milkshakeuk
Labels
bug The result of a coding Error
Projects
NHapi Kanban
Milestone
v3.0.0

Comments

@kulgg
Copy link
Contributor

kulgg commented May 4, 2021

Description
You can find bad inputs with corresponding stack trace in unique_min_crashes and the byte input files in CrashesDeduplicatedMinimized:

Run2 Results
@kulgg
Copy link
Contributor Author

kulgg commented May 20, 2021

Just to add, since i'm done with fuzzing this: If anybody wants to fuzz test in the future i pushed my NHapi-Fuzz-Environment

@milkshakeuk milkshakeuk self-assigned this May 31, 2021
milkshakeuk added a commit that referenced this issue May 31, 2021
@milkshakeuk
Add changes to fix bad input from fuzzing, Fixes #210
10b976b 
* Add new SupportClass.CharsAreUnique method
* Add check for unique encoding charcters in EncodingCharcters.cs (was causing Stack Overflow)
* Add unit tests for changes plus additional Bad Input files to existing test
milkshakeuk added a commit that referenced this issue May 31, 2021
@milkshakeuk
Add changes to fix bad input from fuzzing, Fixes #210
710d55b 
* Add new SupportClass.CharsAreUnique method
* Add check for unique encoding characters  in EncodingCharacters.cs (was causing Stack Overflow)
* Add unit tests for changes plus additional Bad Input files to existing test
@milkshakeuk milkshakeuk mentioned this issue May 31, 2021
Merged
@milkshakeuk milkshakeuk added bug The result of a coding Error and removed awaiting review labels Jun 1, 2021
@milkshakeuk milkshakeuk added this to To Do in NHapi Kanban via automation Jun 1, 2021
@milkshakeuk milkshakeuk moved this from To Do to In Progress in NHapi Kanban Jun 1, 2021
@milkshakeuk milkshakeuk added this to the v3.0.0.0 milestone Jun 1, 2021
NHapi Kanban automation moved this from In Progress to Development Done Jun 1, 2021
milkshakeuk added a commit that referenced this issue Jun 1, 2021
@milkshakeuk
Merge pull request #217 from nHapiNET/FuzzBadInputFixes3
87ced83 
Add changes to fix bad input from fuzzing, Fixes #210
@milkshakeuk milkshakeuk moved this from Development Done to In Pre-Release in NHapi Kanban Jun 2, 2021
@milkshakeuk milkshakeuk moved this from In Pre-Release to Development Done in NHapi Kanban Jun 2, 2021
@milkshakeuk milkshakeuk moved this from Development Done to In Pre-Release in NHapi Kanban Jun 2, 2021
@milkshakeuk milkshakeuk moved this from In Pre-Release to Released in NHapi Kanban Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milkshakeuk milkshakeuk

Labels
bug The result of a coding Error
Projects
No open projects
NHapi Kanban
Released
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

Add changes to fix bad input from fuzzing, Fixes #210 nHapiNET/nHapi
2 participants
@milkshakeuk @kulgg