Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple NHapi source code generation from NHapi.Base #130

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Decouple NHapi source code generation from NHapi.Base #130

merged 2 commits into from
Jan 27, 2021

Conversation

milkshakeuk
Copy link
Member

Closes #127

Update HL7Exception to remove dependency on TableRepository and IHapiLog

Decouple source generation from NHapi.Base

  • Create new project and move source generating source code to it

@milkshakeuk milkshakeuk added this to the v3.0.0.0 milestone Dec 11, 2020
@milkshakeuk milkshakeuk self-assigned this Dec 11, 2020
@milkshakeuk milkshakeuk added this to In Progress in NHapi Kanban via automation Dec 11, 2020
@milkshakeuk
Update HL7Exception to remove dependency on TableRepository and IHapiLog
bcd4774 
* Adds enum for ErrorCode, AcknowledgementCode in line with hapi implementation
* Includes unit tests for ErrorCodeExtensions
@milkshakeuk
Copy link
Member Author

@duaneedwards @Usualdosage @ryankelley Could you have a look when you get a second please.

Thanks!

@milkshakeuk
Copy link
Member Author

@duaneedwards @ryankelley @Usualdosage have you guys had any chance to look over this yet?

@milkshakeuk
Decouple source generation from NHapi.Base
33278ef 
* Create new project and move source generating source code to it
@milkshakeuk milkshakeuk merged commit 9308e04 into master Jan 27, 2021
NHapi Kanban automation moved this from In Progress to Development Done Jan 27, 2021
@milkshakeuk
Copy link
Member Author

@duaneedwards @Usualdosage @ryankelley
Merged PR since it has been here a while now and no one has had the chance to review.
More than willing to revert if anyone has issues to discuss.

@milkshakeuk milkshakeuk deleted the SourceGenSplit branch January 29, 2021 20:08
@milkshakeuk milkshakeuk moved this from Development Done to In Pre-Release in NHapi Kanban Jan 30, 2021
@milkshakeuk milkshakeuk moved this from In Pre-Release to Released in NHapi Kanban Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duaneedwards duaneedwards Awaiting requested review from duaneedwards

@ryankelley ryankelley Awaiting requested review from ryankelley

@Usualdosage Usualdosage Awaiting requested review from Usualdosage

Assignees

@milkshakeuk milkshakeuk

Labels
enhancement
Projects
No open projects
NHapi Kanban
Released
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Split out source code generation from Nhapi.Base
1 participant
@milkshakeuk