Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify cspoj through use of props and targets files #256

Merged
merged 1 commit into from
Jan 1, 2022

Conversation

milkshakeuk
Copy link
Member

  • includes common nuspec details removing the need to update each file
  • assemblies signed through use of props file instead of detailed in each csproj
  • now generates assembly info files from csproj + targets (allows assembly versions to be unique per project)
  • attaches repo + commit to nuspec + assembly info through use of Microsoft.SourceLink.GitHub nuget package
  • the above is configurable though csproj properties

@AMCN41R @PhantomGrazzler could you please review?
Ill prep a release after this PR.

* includes common nuspec details removing the need to update each file
* assemblies signed through use of props file instead of detailed in each csproj
* now generates assembly info files from csproj + targets (allows assembly versions to be unique per project)
* attaches repo + commit to nuspec + assembly info through use of Microsoft.SourceLink.GitHub nuget package
* the above is configurable though csproj properties
@milkshakeuk milkshakeuk added the CI/CD Continuous integration, continuous delivery, and continuous deployment label Dec 29, 2021
@milkshakeuk milkshakeuk added this to the v3.1.0 milestone Dec 29, 2021
@milkshakeuk milkshakeuk added this to In Progress in NHapi Kanban via automation Dec 29, 2021
@github-actions
Copy link

Unit Test Results

       5 files     106 suites   19s ⏱️
1 057 tests 1 051 ✔️   6 💤 0 ❌
2 019 runs  2 008 ✔️ 11 💤 0 ❌

Results for commit 01feef1.

@milkshakeuk milkshakeuk merged commit 3c6d1d6 into master Jan 1, 2022
NHapi Kanban automation moved this from In Progress to Development Done Jan 1, 2022
@milkshakeuk milkshakeuk deleted the build-props-targets branch January 1, 2022 18:32
@milkshakeuk milkshakeuk moved this from Development Done to In Pre-Release in NHapi Kanban Jan 1, 2022
@milkshakeuk milkshakeuk moved this from In Pre-Release to Released in NHapi Kanban Jan 1, 2022
@milkshakeuk
Copy link
Member Author

@PhantomGrazzler @AMCN41R I have released v3.1.0 happy new year! ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous integration, continuous delivery, and continuous deployment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants