Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Refactor of Source Generation #283

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Enable Refactor of Source Generation #283

merged 3 commits into from
Mar 30, 2022

Conversation

milkshakeuk
Copy link
Member

  • Swap from OdbcConnection to OleDbConnection (makes use of connection pools but is only supported on windows)
  • Only target netstandard2.0 for NHapi.SourceGeneration
  • Only target net6 for ModelGenerator and NHapi.NUnit.SourceGeneration (net35 is not required to generate source code)
  • Safe cross platform generation of directory and file paths
  • Abstract IO (File Creation) in NHapi.SourceGeneration with FileAbstraction
  • Add unit tests utilising FileAbstraction enables ability to refactor database access and source generation and ensure the results remain unchanged

@AMCN41R I finally did the work to enable refactoring the SourceGen stuff, if you get chance could you have a peak?

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…ction pools but is only supported on windows)

* only target `netstandard2.0` for `NHapi.SourceGeneration`
* only target `net6` for `ModelGenerator` and `NHapi.NUnit.SourceGeneration` (`net35` is not required to generate source code)
…tion`

* Add unit tests utilising `FileAbstraction` enables ability to refactor database access and source generation and ensure the results remain unchanged
@github-actions
Copy link

Unit Test Results

       5 files     111 suites   19s ⏱️
1 131 tests 1 054 ✔️ 77 💤 0 ❌
2 096 runs  2 014 ✔️ 82 💤 0 ❌

Results for commit c0d35a6.

@milkshakeuk milkshakeuk merged commit 48ad28a into master Mar 30, 2022
@milkshakeuk milkshakeuk deleted the SourceGenRefactor branch March 30, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant