Add Support for CharSetUtil and PreParser resolves #312 #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milkshakeuk
force-pushed
the
PreParser
branch
2 times, most recently
from
9128106
to
63a3ce4
Compare
milkshakeuk
force-pushed
the
PreParser
branch
from
63a3ce4
to
e9528fc
Compare
milkshakeuk
force-pushed
the
PreParser
branch
from
e9528fc
to
5c83c59
Compare
milkshakeuk
force-pushed
the
PreParser
branch
from
5c83c59
to
60adaf3
Compare
jakubsuchybio
approved these changes
Oct 19, 2022
* fix GetBom bom check by adjusting list order * Add tests for CheckCharset with byte array input - indrectly tests above * Xml.cs supports ignoring segment groups but not the nested segments
milkshakeuk
force-pushed
the
PreParser
branch
from
60adaf3
to
a8409fb
Compare
AMCN41R
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per description, should resolve #312, not sure it fully satifies the ask since the some of the methods are internal as per the source of the port.
@AMCN41R could you review this if you get a sec?
@jakubsuchybio should be what you were looking for, well appart from
CharSetUtility.CheckCharsetbeing internal.