Fix Metar Decoding / Wind check for Wind Chill (#1072)

* Fix Metar Decoding / Wind check for Wind Chill PR aims to fix the bug #1071 by checking both the wind speed and it's value for starting Wind Chill calculation.
nabeelio · Mar 15, 2021 · e45bd66 · e45bd66
1 parent b9e7a2e
commit e45bd66
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/app/Support/Metar.php b/app/Support/Metar.php
@@ -1772,7 +1772,7 @@ private function calculate_heat_index($temperature_f, $rh): void
      */
     private function calculate_wind_chill($temperature_f): void
     {
-        if ($temperature_f < 51 && $this->result['wind_speed'] !== 0) {
+        if ($temperature_f < 51 && $this->result['wind_speed'] && $this->result['wind_speed'] !== 0) {
             $windspeed = $this->result['wind_speed']->toUnit('mph');
             if ($windspeed > 3) {
                 $chill_f = 35.74 + 0.6215 * $temperature_f - 35.75 * ($windspeed ** 0.16);

diff --git a/tests/MetarTest.php b/tests/MetarTest.php
@@ -151,6 +151,19 @@ public function testMetar4Clouds()
         $this->assertEquals('Few at 1500 feet; few at 25000 feet', $metar['clouds_report_ft']);
     }
 
+    /**
+     * https://github.com/nabeelio/phpvms/issues/1071
+     */
+    public function testMetarWindSpeedChill()
+    {
+        $metar = 'EKYT 091020Z /////KT CAVOK 02/M03 Q1019';
+        $metar = Metar::parse($metar);
+
+        $this->assertEquals('VFR', $metar['category']);
+        $this->assertNull($metar['wind_speed']);
+        $this->assertEquals(6.21, $metar['visibility']['mi']);
+    }
+
     /**
      * Visibility in KM not parsed
      *