Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metar Decoding Error / Wind Chill Calculation #1071

Closed
FatihKoz opened this issue Mar 9, 2021 · 0 comments · Fixed by #1072
Closed

Metar Decoding Error / Wind Chill Calculation #1071

FatihKoz opened this issue Mar 9, 2021 · 0 comments · Fixed by #1072

Comments

@FatihKoz
Copy link
Contributor

FatihKoz commented Mar 9, 2021 •
edited
Loading

Describe the bug
When no wind is reported by the station metar decoding function can not calculate (or skip) wind chill and gives an error.

Version
Latest Dev

To Reproduce
Steps to reproduce the behavior:

  1. Use this metar for testing : EKYT 091020Z /////KT CAVOK 02/M03 Q1019
  2. See the error

Expected behavior
Wind Chill calculation should not start calculation if no wind is reported

unknown
@FatihKoz FatihKoz mentioned this issue Mar 9, 2021
Merged
@nabeelio nabeelio linked a pull request Mar 9, 2021 that will close this issue
Fix Metar Decoding / Wind check for Wind Chill #1072
Merged
nabeelio pushed a commit that referenced this issue Mar 15, 2021
@FatihKoz
Fix Metar Decoding / Wind check for Wind Chill (#1072)
e45bd66 
* Fix Metar Decoding / Wind check for Wind Chill

PR aims to fix the bug #1071 by checking both the wind speed and it's value for starting Wind Chill calculation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Metar Decoding / Wind check for Wind Chill
1 participant
@FatihKoz