Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fuel and Ground Handling Costs not being checked from settings #1048

Closed
FatihKoz opened this issue Feb 26, 2021 · 1 comment
Closed

Fuel and Ground Handling Costs not being checked from settings #1048

FatihKoz opened this issue Feb 26, 2021 · 1 comment

Comments

@FatihKoz
Copy link
Contributor

Describe the bug
If Airport fuel and ground handling costs are not defined pirep finances does not use default prices defined at settings

To Reproduce
Steps to reproduce the behavior:

  1. Remove fuel cost from your departure airport
  2. Remove ground handling cost from your arrival airport
  3. File a manual pirep or just re-calculate finances of a previous pirep using edited airports
  4. Check finances / no fuel and gh cost will be there

Expected behavior
Finances should use the default settings if airport costs are not defined
@FatihKoz FatihKoz mentioned this issue Feb 26, 2021
Merged
nabeelio added a commit that referenced this issue Mar 18, 2021
@FatihKoz @nabeelio
Fix for Fuel and Ground Handling Costs (#1050)
1d83b85 
* Fix for Fuel and Ground Handling Costs

PR aims to fix issue #1048  and implements the feature request #1049 

If no fuel cost is defined for departure airport, settings / airport fuel price will be used.
If no ground handling cost is defined for airports, settings / airport ground handling cost will be used.

Ground handling prices of both departure and arrival airport will be used for calculations.

* Resolve conflict with latest dev

PR will still fail checks due to double ground handling fares and will work on it to have two records at transactions for dep/arr

* Remove Double GH Costs / Fix The Bug Only

Removed double GH costs for now, pr aims only fixing the current issue (general settings not being read for fuel and ground handling costs)

* Add departure and arrival airports to ground handling

* Style fix

* Fix tests

Co-authored-by: Nabeel S <nabeelio@users.noreply.github.com>
Co-authored-by: Nabeel Shahzad <nabeel@nabeel.sh>
@FatihKoz
Copy link
Contributor Author

Closed with PR #1050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FatihKoz