Fix for Fuel and Ground Handling Costs #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR aims to fix issue #1048 and implements the feature request #1049 If no fuel cost is defined for departure airport, settings / airport fuel price will be used. If no ground handling cost is defined for airports, settings / airport ground handling cost will be used. Ground handling prices of both departure and arrival airport will be used for calculations.
nabeelio
reviewed
Feb 26, 2021
PR will still fail checks due to double ground handling fares and will work on it to have two records at transactions for dep/arr
Removed double GH costs for now, pr aims only fixing the current issue (general settings not being read for fuel and ground handling costs)
|
Would be nice, to see that bug fixed |
This was referenced Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR aims to fix issue #1048
If no fuel cost is defined for departure airport, settings / airport fuel price will be used.
If no ground handling cost is defined for airports, settings / airport ground handling cost will be used.