Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin role does not have "disable_activity_checks" enabled #1412

Closed
Tracked by #1413
FatihKoz opened this issue Feb 20, 2022 · 0 comments · Fixed by #1413
Closed
Tracked by #1413

Admin role does not have "disable_activity_checks" enabled #1412

FatihKoz opened this issue Feb 20, 2022 · 0 comments · Fixed by #1413
Labels
bug
Milestone
7.0.0

Comments

@FatihKoz
Copy link
Contributor

FatihKoz commented Feb 20, 2022 •
edited
Loading

Admin role does not have "disable_activity_checks" enabled and there are no admin protections at daily on leave checks.

Version
7.0.0-dev+220217.648659

To Reproduce

  • Easiest way is to check is going through database
  • Or maybe checking $user->roles()->where('disable_activity_checks', 1)->count() with dump etc
  • Or make your admin eligible to be identified as inactive (delete pireps, set related user dates to 4-5 months back) , then run daily cron

Expected behavior
Default admin role should have disable_activity_checks set to true

Screenshots
unknown

Additional context
https://github.com/nabeelio/phpvms/blob/dev/app/Services/UserService.php#L308-L343
@nabeelio nabeelio added the bug label Mar 1, 2022
@nabeelio nabeelio added this to the 7.0.0 milestone Mar 1, 2022
@nabeelio nabeelio mentioned this issue Mar 8, 2022
Merged
7 tasks
@nabeelio nabeelio linked a pull request Mar 8, 2022 that will close this issue
Laravel 9 Update #1413
Merged
7 tasks
nabeelio added a commit that referenced this issue Mar 9, 2022
@nabeelio
Disable admin activity checks #1412
cc0cad1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Laravel 9 Update nabeelio/phpvms
2 participants
@nabeelio @FatihKoz