Laravel 9 Update

[nabeelio]

Upgrade Guide

• WITH THIS UPDATE, PHPVMS NOW REQUIRES PHP 8.0+
• Please read through the Laravel Upgrade Guide - there are some settings that are moved/deprecated, and they may apply to you, if you have customized those settings
• The SMTP stream options like verify_peer have moved to the root of the SMTP settings. See the Laravel upgrade guide, under "SMTP Stream Options"
• Any modules/themes will need to be updated for casting fuel and other types properly (see notes below)
• The captcha has been changed to use hCaptcha

Notes

• laravel-gamp (google analytics) removed a) library version incompatible b) wanting to remove google analytics from being included because of gdpr, etc
• Fuel/distance are being properly casted now the Fuel and Distance styles, so usages of those need to be updated, so something like $pirep->fuel_used->internal([rounding]) to get the value. There are several methods: internal() gets the unit in its internal storage format, local() to the unit that the user has selected to view them as, in the admin panel. Both methods take an optional rounding value

Template Changes

• resources/views/layouts/default/app.blade.php
• resources/views/layouts/default/downloads/table.blade.php

Task List

• Rewrite the API status caller (reports version, which was removed)
• Refactor factories so they're using the new style
• Models use new accessor formats
• Replace recaptcha with hcaptcha
• Move to Symfony Mailer
• Update GH actions to use PHP8
• Admin role does not have "disable_activity_checks" enabled #1412

[FatihKoz]

Fresh install with php8.1.3 is not possible, below exception occurs.

[2022-03-09 17:35:35] dev.INFO: Redirecting to database setup  
[2022-03-09 17:35:35] production.ERROR: Attribute value must be of type bool for selected attribute, string given {"exception":"[object] (TypeError(code: 0): Attribute value must be of type bool for selected attribute, string given at D:\\Projects\\v7\\vendor\\laravel\\framework\\src\\Illuminate\\Database\\Connectors\\Connector.php:70)
[stacktrace]
#0 D:\\Projects\\v7\\vendor\\laravel\\framework\\src\\Illuminate\\Database\\Connectors\\Connector.php(70): PDO->__construct('mysql:host=127....', 'root', '', Array)
#1 D:\\Projects\\v7\\vendor\\laravel\\framework\\src\\Illuminate\\Database\\Connectors\\Connector.php(46): Illuminate\\Database\\Connectors\\Connector->createPdoConnection('mysql:host=127....', 'root', '', Array)
#2 D:\\Projects\\v7\\vendor\\laravel\\framework\\src\\Illuminate\\Database\\Connectors\\MySqlConnector.php(24): Illuminate\\Database\\Connectors\\Connector->createConnection('mysql:host=127....', Array, Array)

[FatihKoz]

Fresh install with php8.0.16 works fine.

[FatihKoz]

Exporting expenses still do not work

Re-Create;

• Fresh install
• Add a new test expense
• Try to export

[FatihKoz]

Testing the branch on my live site, with flights and daily ops.

This error shows up every 5 mins on my laravel log.

[2022-03-13 17:20:02] prod.ERROR: Class "PDO" not found {"exception":"[object] (Error(code: 0): Class \"PDO\" not found at /vendor/laravel/framework/src/Illuminate/Database/Connection.php:1470)

PDO Error.txt

Trying to figure out what it can be, cron or a module or something else ? Not much clues in the error and stack trace below.

[FatihKoz]

And this is the last entry from my cron log, this makes me think that above PDO error is somehow related with cron.

[2022-03-13 13:20:02] prod.ERROR: Command "version" is not defined.

Did you mean one of these?
    phpvms:version
    session:table {"exception":"[object] (Symfony\\Component\\Console\\Exception\\CommandNotFoundException(code: 0): Command \"version\" is not defined.

Did you mean one of these?
    phpvms:version
    session:table at /vendor/symfony/console/Application.php:683)
[stacktrace]
#0 /vendor/symfony/console/Application.php(259): Symfony\\Component\\Console\\Application->find()
#1 /vendor/symfony/console/Application.php(171): Symfony\\Component\\Console\\Application->doRun()
#2 /vendor/laravel/framework/src/Illuminate/Console/Application.php(102): Symfony\\Component\\Console\\Application->run()
#3 /vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(129): Illuminate\\Console\\Application->run()
#4 /bin/cron(25): Illuminate\\Foundation\\Console\\Kernel->handle()
#5 {main}

[FatihKoz]

I think the cron error is related to this 'cause it is the only piece of code, running a version command every time cron runs

https://github.com/nabeelio/phpvms/blob/Laravel9/bin/cron#L21-L26

$status = $kernel->handle(
    $input = new Symfony\Component\Console\Input\ArrayInput([
        'command' => 'version',
    ]),
    new Symfony\Component\Console\Output\NullOutput()
);

[nabeelio]

PDO is a PHP class from the PDO driver, maybe something not configured right with the command line PHP? That command throwing an error is strange though, I'll look

[FatihKoz]

This is what I got at cpanel for php8.1

Looks like I have every extension we need there and enabled.

[FatihKoz]

[2022-03-13 18:00:06] prod.INFO: Hourly: Removing expired Simbrief entries

Cron started working again, that suggestion provided with the error worked :) And no repeating errors in laravel log on every cron run.

[FatihKoz]

Also saw this with Discord Notifications

Notice the difference in distance, either it is not sending 0 km or we have an unnecessary / there. Before (with latest dev build) notification was like below