New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check DRAFT state too when deciding auto approval by rank #1422

Merged

nabeelio merged 1 commit into nabeelio:dev from FatihKoz:DraftPirepProblem

Feb 28, 2022

Contributor

FatihKoz commented Feb 28, 2022

If a manual pirep gets saved before being submitted, state is set to DRAFT.
That state is not being considered during auto approval by rank check when the pirep gets submitted.
So it passes the check and gets IN PROGRESS state 'cause it is the default state defined.

Pull request adds DRAFT state to auto approval by rank check.

Closes #1420


          Update PirepService

75852c1

Add DRAFT state in conditional check

nabeelio added the bug label

nabeelio added this to the 7.0.0 milestone

nabeelio merged commit 7a40a9d into nabeelio:dev

Owner

nabeelio commented Feb 28, 2022

Thanks, yeah, draft state was a late addition and slipped through

FatihKoz deleted the DraftPirepProblem branch

February 28, 2022 17:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment