Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needing to approve pirep even when it is auto on #1420

Closed
dougjuk opened this issue Feb 28, 2022 · 2 comments · Fixed by #1422
Closed

Needing to approve pirep even when it is auto on #1420

dougjuk opened this issue Feb 28, 2022 · 2 comments · Fixed by #1422

Comments

@dougjuk
Copy link

dougjuk commented Feb 28, 2022

Describe the bug
I have noticed that in certain circumstances I am having to go in an approve some of the maunal submitted pireps even when the system is set to auto approve.

Version
7.0.0-dev+220225.9d368e - Dispo theme V3 with both basic and special modules

To Reproduce

  1. Select a flight from the schedule
  2. Go to manual pirep
  3. Fill in some basic details and save as draft
  4. Go back to the pirep add the rest of the data and submit

Expected behaviour
It should auto accept the pirep as it does if you just file it without saving as draft

@FatihKoz
Copy link
Contributor

Tried to replicate the steps.

Rank Settings;
d1

Step 2;
d2
Step 3;
d3
Step 4;
d4
d5

Here is the log;
laravel-2022-02-28.log

Disposable addons (including the theme) does not interfere with core's pirep processing stage and according to the log, looks like they do their jobs and cause no errors.

Will try do check core code step by step to see/find where it fails to read (or skip) reading the rank settings.

@FatihKoz
Copy link
Contributor

FatihKoz commented Feb 28, 2022

Additional info,

  • Directly submitting a manual pirep works just fine, so there is definitely something going wrong when a pirep gets saved then submitted from the create/edit form.

d4

  • It even gets auto approved if it gets submitted from pirep details page after being edited.

d6

Same behavior also tested on demo site with no addons and default theme.

d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants