Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimBrief Planning System Update #991

Merged
merged 7 commits into from
Jan 17, 2021
Merged

SimBrief Planning System Update #991

merged 7 commits into from
Jan 17, 2021

Conversation

FatihKoz
Copy link
Contributor

Replaces outdated old pr.

Same improvements apply to both SimBrief Controller and flights / simbrief_form.blade

  • Uses the aircraft_id to get all necessary details to calculate random load according to load factor and variances. (Min and Max protections applied, load factor will never go above 100 and below 1)
  • All possible values are sent to simbrief for more precise and customized flight plan generation
  • Gets current utc time and adds 45mins to it for ETD and Date generation
  • Different pax weights are used for Charter and Scheduled flights (also sent to SimBrief)
  • Calculated random load figures are sent to SimBrief OFP as Dispatch Remark too
  • Automatic SID/STAR type selection added to planning options (RNAV or Conventional)
  • Step Climb logic applied (as per SimBrief documentation, if Step Climbs are enabled no flight level info is needed)
  • Gets user weight settings (KG/LBS) and uses it on both calculations and SimBrief Briefing Options section

FatihKoz and others added 3 commits January 17, 2021 21:53
Replaces outdated old pr.

Same improvements apply to both controller and simbrief_form.blade.
FatihKoz and others added 3 commits January 17, 2021 22:59
changed equals to strict equals and put in some comments about the loadarray and manualrmk generation.
@nabeelio
Copy link
Owner

Changed some formatting (no tabs, only spaces), minor things. Converted secstohhmm to a directive/helper method. Just pull it down and make sure it's all working as expected

@FatihKoz
Copy link
Contributor Author

I do not recall using any @secstohhmm in the simbrief_form ? Anyway, will pull and check both visually and on my test server.

We have the $wakecat, $equipment and $transponder in the controller, removed them from the blade.

Fixed a harmless typo in the IVAO Prefile DEPTIME line
@FatihKoz
Copy link
Contributor Author

Tested both generating new briefings (long and short hauls with different aircrafts, with different seat caps fare classes etc) ... simbrief_form seems working fine.

Also the secstohhmm is working fine in the simbrief_briefing blade.

Why the test is failing at acars route part i have no idea.

@nabeelio nabeelio merged commit 617cea5 into nabeelio:dev Jan 17, 2021
@nabeelio
Copy link
Owner

nabeelio commented Jan 17, 2021

Not sure why either, just needed to be restarted. Finally merged, yay! Thank you for all of your work on this

@FatihKoz
Copy link
Contributor Author

Yes, finally ... Thank you too ;) Without your assistance this may not be possible at all.

I am pleased to have it in the default dev build, hope all users will like it as I did :)

@FatihKoz FatihKoz deleted the simbrief-planning branch January 17, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simbrief Fleet Assignments Use Config Weight units in Simbrief Form Template
2 participants