Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Config Weight units in Simbrief Form Template #921

Closed
trevorhannant opened this issue Nov 9, 2020 · 4 comments · Fixed by #991
Closed

Use Config Weight units in Simbrief Form Template #921

trevorhannant opened this issue Nov 9, 2020 · 4 comments · Fixed by #991
Milestone

Comments

@trevorhannant
Copy link

The simbrief_form.blade.php currently defaults to LBS regardless of the weight unit specified in the config settings.

Rather than admins editing the template on every upgrade, set the selected field for the dropdown to the value set in settings.unit_weight (or units_fuel?)

@macofallico
Copy link
Contributor

macofallico commented Nov 12, 2020

you could easily edit the template or create a custom template and upgrades wont afect you like this:

`<tr>
              <td>Unidades:</td>
              <td><select name="units">
                  <option value="LBS">LBS</option>
                  <option value="KGS" selected>KGS</option>
                </select></td>
            </tr>`

I also added a PAX count selector.

@trevorhannant
Copy link
Author

And how would you call the custom template? Would the simbrief_form.blade.php file not need a call to that which would then be overwritten on an upgrade?

@nabeelio
Copy link
Owner

You can change it in your customized skin (which you should be using). But this is still something that need to be fixed

@nabeelio nabeelio added this to the 7.0.0 milestone Nov 25, 2020
@FatihKoz
Copy link
Contributor

This issue should be closed too, current simbrief_form checks user settings and applies correct selection for KG/LBS.

@nabeelio nabeelio linked a pull request Jan 18, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants