Make iterations in SugiyamaAlgorithm configurable
#57
Conversation
|
This PR introduces some smaller changes that help us increase performance. The first one is making the iterations in I also avoided recalculating some stuff and did some smaller optimizations in I also did some smaller code style changes, but i can revert them if you like. Thanks for taking the time! |
| @@ -863,7 +858,7 @@ class SugiyamaAlgorithm extends Algorithm { | |||
| nodeOrdering(); //expensive operation | |||
| coordinateAssignment(); //expensive operation | |||
| // shiftCoordinates(shiftX, shiftY); | |||
| final graphSize = calculateGraphSize(this.graph); | |||
| //final graphSize = calculateGraphSize(this.graph); | |||
There was a problem hiding this comment.
This was unused so i commented it out 👍🏽
|
Thanks for this. I will create some tests and have a look at this on the weekend |
|
Hi @JulianBissekkou , I have added two tests in the repo, can you please try to run them and see if they pass. Thanks Other than that LGTM |
JulianBissekkou
force-pushed
the
master
branch
from
4ab9d02
to
62ba30c
Compare
|
@nabil6391 Tests are passing! I also created a workflow file that runs tests in master and on every pr. I think you have to enable github actions in the project otherwise I can not test if the workflow works :) |
No description provided.